Skip to content

fix(lenovo): send empty string for OldPassword in Bios.ChangePassword #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinraumann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(lenovo): send empty string for OldPassword in Bios.ChangePassword #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/lenovo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,10 +883,19 @@ impl Redfish for Bmc {
current_uefi_password: &'a str,
new_uefi_password: &'a str,
) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
let current_pw = current_uefi_password.to_string();
let new_pw = new_uefi_password.to_string();
let s = self.s.clone();
Box::pin(async move {
self.s
.change_bios_password(UEFI_PASSWORD_NAME, current_uefi_password, new_uefi_password)
.await
// Lenovo BMC requires explicit empty string "" for OldPassword, not null.
// This is handled explicitly by building the HashMap with String values
// instead of Option<String>, ensuring empty passwords serialize as "" not null.
let url = format!("Systems/{}/Bios/Actions/Bios.ChangePassword", s.system_id());
let mut arg = HashMap::new();
arg.insert("PasswordName", UEFI_PASSWORD_NAME.to_string());
arg.insert("OldPassword", current_pw); // Empty string stays as ""
arg.insert("NewPassword", new_pw);
s.client.post(&url, arg).await.map(|_resp| Ok(None))?
})
}

Expand Down