feat(mobile): bypass GPS proximity check on iOS browsers via RemoteConfig - #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bypasses the GPS proximity check specifically when running inside iOS web browsers (Safari, Chrome on iOS, iPadOS web), allowing experiences to be played without location gating.
Integrated with the
RemoteConfigarchitecture (GET /config) so the behavior can be toggled on/off dynamically from the server viaBYPASS_GEOFENCE_IOS_BROWSERenv var without client recompilation or redeployment.Resolves #435
Reasoning
Web geolocation on iOS Safari / iOS Web exhibits precision and permissions issues that often prevent legitimate listeners from playing experiences even when on site.
Enforcing proximity check on Android Web, Desktop Web, and native iOS/Android apps is preserved, while iOS Web listeners are unblocked.
Changes
bypassIosBrowser: z.boolean().default(true)toRemoteConfigPayloadSchema.geofenceandDEFAULT_REMOTE_CONFIG.BYPASS_GEOFENCE_IOS_BROWSERparsing intoconfigGuardmiddleware and served dynamicgeofence.bypassIosBrowserinGET /config.isIosBrowser()helper detecting iOS Web environments (iPhone/iPad UA or iPadOS touch points onPlatform.OS === 'web').useOfflineGeofencewhenisIosBrowser() && config.geofence.bypassIosBrowser.Test Plan
bun test --cwd packages/shared(165 passed)bun run --cwd apps/api test(512 passed)bun run --cwd apps/mobile jest(580 passed)bun run --cwd apps/mobile typecheck&bun run --cwd apps/api typecheck(0 errors)bun run --cwd apps/mobile lint&bun run --cwd apps/api lint(0 errors)bun x react-doctor --verbose --diff(Score: 100/100)