docs(index): fix quickstart Step 2 to use fluent API - #3
Merged
Conversation
…ey/WithAuthDomain API FirebaseOptions has private setters — the old property-assignment style (options.ApiKey = "...") doesn't compile. Replace it with the fluent builder pattern already used everywhere else in the docs. Closes #2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
options.ApiKey = "...") which does not compile —FirebaseOptionshasprivate seton all properties.WithProject(),WithApiKey(),WithAuthDomain()) that matches the actual API and is already used ingetting-started.html.Root cause
FirebaseOptionsexposes properties withprivate set, so they can only be set via the fluentWith*()methods. The homepage quickstart was never updated after the API was changed.Test plan
getting-started.htmluses the same pattern (it does, no change needed)FirebaseOptions(confirmed — onlyFirebaseAuthorizationOptionsuses property assignment, which has public setters)Closes #2