peremoga - #1330
Open
Kit3AWP wants to merge 2 commits into
Open
Conversation
brespect
suggested changes
Jul 26, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Almost done, let's fix few comments and the UI:
Comment on lines
+9
to
+17
| if (filter === 'Active') { | ||
| return !todo.completed; | ||
| } | ||
|
|
||
| if (filter === 'Completed') { | ||
| return todo.completed; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
better to use switch here with enum values
Comment on lines
+17
to
+21
| if (normalizedTitle === '') { | ||
| deleteTodo(todo.id); | ||
| } else if (normalizedTitle !== todo.title) { | ||
| renameTodo(todo.id, normalizedTitle); | ||
| } |
Comment on lines
+57
to
+62
| onKeyUp={event => { | ||
| if (event.key === 'Escape') { | ||
| setEditText(todo.title); | ||
| setIsEditing(false); | ||
| } | ||
| }} |
Comment on lines
+79
to
+89
| onClick={() => { | ||
| deleteTodo(todo.id); | ||
|
|
||
| const newTodoField = document.querySelector( | ||
| '[data-cy="NewTodoField"]', | ||
| ) as HTMLInputElement; | ||
|
|
||
| if (newTodoField) { | ||
| newTodoField.focus(); | ||
| } | ||
| }} |
There was a problem hiding this comment.
create a separate handler for burger functions
Comment on lines
+16
to
+43
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'All' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter('All')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === 'Active' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter('Active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === 'Completed' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter('Completed')} | ||
| > | ||
| Completed | ||
| </a> | ||
| </nav> |
Comment on lines
+49
to
+59
| onClick={() => { | ||
| clearCompleted(); | ||
|
|
||
| const newTodoField = document.querySelector( | ||
| '[data-cy="NewTodoField"]', | ||
| ) as HTMLInputElement; | ||
|
|
||
| if (newTodoField) { | ||
| newTodoField.focus(); | ||
| } | ||
| }} |
| return ( | ||
| <div | ||
| data-cy="Todo" | ||
| className={`todo ${todo.completed ? 'completed' : ''} ${isEditing ? 'editing' : ''}`} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK