Complete React Todo app - #1336
Open
devsync25 wants to merge 3 commits into
Open
Conversation
brespect
suggested changes
Aug 25, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Almost done, but let's fix the UI input focus:
Comment on lines
+195
to
+226
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'all' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter('all')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${ | ||
| filter === 'active' ? 'selected' : '' | ||
| }`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter('active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${ | ||
| filter === 'completed' ? 'selected' : '' | ||
| }`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter('completed')} | ||
| > | ||
| Completed | ||
| </a> | ||
| </nav> |
roman-mirzoian
suggested changes
Aug 26, 2026
roman-mirzoian
left a comment
roman-mirzoian
left a comment
There was a problem hiding this comment.
The demo link still points to the old version—don't forget to update the deployment and double-check for yourself that the updated version opens when you click your link:
roman-mirzoian
suggested changes
Aug 26, 2026
roman-mirzoian
left a comment
roman-mirzoian
left a comment
There was a problem hiding this comment.
I can see that the deployment has definitely been updated, but the app itself still doesn't look like it's been fixed. Please make sure that the demo link opens the fixed app before submitting the next review request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://devsync25.github.io/react_todo-app/