Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Dec 31, 2025

This PR fixes a problem with dialogs opening at the top of the page and sometimes scrolling to the top. The original position: relative CSS is the problem, and it is resolves by using position: fixed. That means the dialogs don't scroll with he page as they did in 4.1, but I don't see a problem with that.

Resolves issue mathjax/MathJax#3480.

@dpvc dpvc requested a review from zorkow December 31, 2025 17:52
@dpvc dpvc added this to the v4.1.1 milestone Dec 31, 2025
@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.50%. Comparing base (82cabf4) to head (d1ff109).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1403   +/-   ##
========================================
  Coverage    86.50%   86.50%           
========================================
  Files          340      340           
  Lines        85952    85952           
  Branches      4816     4816           
========================================
  Hits         74357    74357           
  Misses       11572    11572           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants