Patch - minor edits and typos etc. - #11
Open
gaksaray wants to merge 2 commits into
Open
Conversation
added 2 commits
July 21, 2022 22:48
Owner
|
Thanks so much!
I do prefer to make changes myself. Could you list what you found?
Norm
|
Author
|
Sure, no problem. Would commenting my changes on README.md file work for you? |
Owner
|
Yes, that would be great, thanks in advance.
Norm
…On Wed, Jul 27, 2022 at 12:58:19AM -0700, Gorkem Aksaray wrote:
Sure, no problem. Would commenting my changes on README.md file work
for you?
—
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
You are receiving this because you commented. Message ID:
***@***.***>
References
1. #11 (comment)
2. https://github.com/notifications/unsubscribe-auth/ABZ34ZKJRN6W7TZ76P4UIWTVWDTZXANCNFSM54RDABYQ
|
gaksaray
commented
Jul 28, 2022
gaksaray
left a comment
gaksaray
left a comment
Author
There was a problem hiding this comment.
Changes commented for your review
| > include spaces, and must start with a letter.) | ||
|
|
||
| Note that **n81100** now is a 21-element vector. Its first element is | ||
| Note that **n81100** now is a 20-element vector. Its first element is |
Author
There was a problem hiding this comment.
Incorrect vector length n81100
|
|
||
| So the 4th, 8th, 9th etc. elements in **Nile** had the queried property. | ||
| (Note that those were years 1875, 1879 and so on.) | ||
| (Note that those were years 1874, 1878 and so on.) |
Author
There was a problem hiding this comment.
Correction on corresponding years for Nile data
| i.e. the height, weight and age of that person. | ||
|
|
||
| **Note that that row would also be cnsidered a vector. The third column | ||
| **Note that that row would also be considered a vector. The third column |
| > ?ToothGrowth | ||
| ``` (The data turn out to be on guinea pigs, with orange juice or | ||
| ``` | ||
| (The data turn out to be on guinea pigs, with orange juice or |
Author
There was a problem hiding this comment.
Note was written on the same line as previous code fence so it didn't appear as distinct line
|
|
||
| ``` r | ||
| > nrow(ToothGrowth) | ||
| > nrow(tg) |
Author
There was a problem hiding this comment.
Previous and following code blocks use tg as shorthand for ToothGrow so these can be changed to tg to stay consistent
| ``` | ||
|
|
||
| So, the risk of diabetes increases substantial over that 10-year period, | ||
| So, the risk of diabetes increases substantially over that 10-year period, |
| * The condition within the 'while' says that (a) we are not yet at the | ||
| end of the **airpass** vector, AND (b) our total is still less than | ||
| 10000. | ||
| end of the **airpass** vector, AND (b) our total is still less than 10000. |
Author
There was a problem hiding this comment.
This didn't appear correctly in html form so moved 10,000 to previous line
|
|
||
| There's more, though. The **cumsum** function is vectorized, so using | ||
| it, though seemingly wasteful, may actually be faster than the loop | ||
| it, though seemingly wasteful, may actually be faster than the loop. |
| ## <a name="ide"> Installing and Using IDEs </a> | ||
|
|
||
| An *interactive development environment* (IDE) is a software tool that | ||
| An *integrated development environment* (IDE) is a software tool that |
Author
There was a problem hiding this comment.
Did you mean "integrated"?
https://en.m.wikipedia.org/wiki/Integrated_development_environment
|
|
||
| The real "power users" tend to use either Emacs Speaks Statistics (ESS), | ||
| a plugin for the Emacs editor, or Nvim-r,, a plugin for the vim editor. | ||
| a plugin for the Emacs editor, or Nvim-r, a plugin for the vim editor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.