Bitfool fasteR fixes - #8
Open
bitfool wants to merge 4 commits into
Open
Conversation
Nile[1] is 1871, so Nile[4] is 1874 (not 1875) and Nile[x] is x+1870, not x+1871
Owner
|
I highly appreciate your doing this, and look forward to your future comments. But since this is prose, not code, thus not subject to unit tests and so on, I much prefer that you simply give me your comments directly, rather than as pull requests. |
Author
|
Gladly I will do so; I did not want to presume to use your UC Davis email,
but guess I will since I see no DM here on github.
Paul Howell ***@***.***
Bitfool LLC 734.546.6596
…On Mon, Apr 4, 2022 at 4:01 PM Norm Matloff ***@***.***> wrote:
I highly appreciate your doing this, and look forward to your future
comments. But since this is prose, not code, thus not subject to unit tests
and so on, I much prefer that you simply give me your comments directly,
rather than as pull requests.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQMR22MGDVATSBNHZES3DVDNC7TANCNFSM5SOFR4GA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my first pull request, just a few minor typos and a more significant error I think in the dates for the Nile data. thanks for this resource, am offering minor fixes from my first evening working through your materials and learning R.