change(notification_client): use cross process locking event and media stores instead of in-memory ones #5934
+95
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5934 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 363 363
Lines 103469 103493 +24
Branches 103469 103493 +24
=======================================
+ Hits 91582 91611 +29
+ Misses 7533 7528 -5
Partials 4354 4354 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5934 will not alter performanceComparing Summary
|
…a stores instead of in-memory ones This will allow the NSE process to populate the event cache store with even data after retrieving it from sync, as opposed to dropping after rendering the notification it as it did previously.
stefanceriu
force-pushed
the
stefan/notificationClientCrossProcessLockingStores
branch
from
e377d58 to
a836b72
Compare
Hywan
requested changes
Dec 19, 2025
crates/matrix-sdk-base/src/client.rs
Outdated
Comment on lines
232
to
233
| event_cache_store: self.event_cache_store.clone(), | ||
| media_store: self.media_store.clone(), |
Member
There was a problem hiding this comment.
You're cloning the EventCacheStoreLock and MediaStoreLock, with the main cross-process holder name. It doesn't use the new cross_process_store_locks_holder_name received by argument here.
Hywan
force-pushed
the
stefan/notificationClientCrossProcessLockingStores
branch
from
ddab0d2 to
d6e8dae
Compare
This patch renames `clone_with_in_memory_state_store` to `derive_states_for_notification_client`. At least it clarifies what it does.
Hywan
force-pushed
the
stefan/notificationClientCrossProcessLockingStores
branch
from
77931b6 to
116003a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the NSE process to populate the event cache store with even data after retrieving it from sync, as opposed to dropping after rendering the notification it as it did previously.