-
Notifications
You must be signed in to change notification settings - Fork 362
Allow focused timelines to replace UTDs after redecryption #5955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #5955 will not alter performanceComparing Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5955 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 363 363
Lines 103480 103510 +30
Branches 103480 103510 +30
==========================================
+ Hits 91594 91641 +47
+ Misses 7532 7513 -19
- Partials 4354 4356 +2 ☔ View full report in Codecov by Sentry. |
|
@jmartinesp or @stefanceriu this would probably be a good candidate for live testing with EX. I don't think I changed anything except the UTD -> decrypted codepath, and there are some tests confirming this, but it would be wise to double check that this didn't break something accidentally. A good test would be to login and open a pinned timeline and see if UTDs get resolved correctly and if nothing else is broken with the pinned timeline. |
|
I don't know what to say, it's not looking good Simulator.Screen.Recording.-.iPhone.Air.-.2025-12-12.at.12.36.13.mov
|
This should allow us in the future to create more such tests with many more events.
…have the same event ID
This time we're testing the redecryption of pinned events that were not part of the main timeline, more importantly we never backpaginated enough for them to be part of the main timeline and thus never got put into the event cache. This test expectedly fails for now.
0ef55e3 to
27be8e5
Compare
|
Alright, I added another test which confirms what we suspected. If the pinned events aren't part of the main timeline and thus never get put into the event cache, then R2D2 can't find them to decrypt them. This is why the events in the video aren't decrypted. I also found another issue where we would replace events with the incorrect thing because the mapping from event cache index to timeline index is broken. |
Hywan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with that as a first step. Thanks!
This partially and very hackishly fixes a problem where focused timelines don't replace UTDs after the event cache redecrypts the event.
The problem is more closely described in #5954.
This closes: #5798. Probably #5703 as well but I still need to write a test for that one.