Skip to content

Conversation

@Hywan
Copy link
Member

@Hywan Hywan commented Dec 16, 2025

Based on top of #5968. Must be merged before.

We can't use LatestEventValue::None as an optional value anymore, since it erases the previous LatestEventValue. This patch update LatestEventValueBuilder::new_local to return an Option to handle all the cases where a local value cannot be computed.


@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025

CodSpeed Performance Report

Merging #5969 will not alter performance

Comparing Hywan:fix-issue-5958 (059bcd2) with main (4e90cea)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 91.04478% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (4e90cea) to head (059bcd2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rates/matrix-sdk/src/latest_events/latest_event.rs 90.62% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5969   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         363      363           
  Lines      103590   103638   +48     
  Branches   103590   103638   +48     
=======================================
+ Hits        91688    91738   +50     
+ Misses       7538     7534    -4     
- Partials     4364     4366    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan force-pushed the fix-issue-5958 branch 2 times, most recently from 9f852ff to 98b4bf8 Compare December 16, 2025 12:47
We can't use `LatestEventValue::None` as an optional value anymore,
since it erases the previous `LatestEventValue`. This patch updates
`LatestEventValueBuilder::new_local` to return an `Option` to handle all
the cases where a local value cannot be computed.
@Hywan Hywan marked this pull request as ready for review December 16, 2025 12:50
@Hywan Hywan requested a review from a team as a code owner December 16, 2025 12:50
@Hywan Hywan requested review from jmartinesp and stefanceriu and removed request for a team and stefanceriu December 16, 2025 12:50
Copy link
Contributor

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Hywan Hywan merged commit e57185a into matrix-org:main Dec 16, 2025
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sending a reaction temporarily bumps a room to the *bottom* of the list.

2 participants