This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add support for K70 Rapidfire (non-RGB) 0x1b3a#86
Closed
hevanaa wants to merge 10 commits into
Closed
Conversation
Incorporate suggestions from @light2yellow from the PR.
AUR Package based on qmake
Add `CMD/Shift+select` issue to Known Issues
|
@koanya can you test it? |
Collaborator
|
Please base this PR against testing. |
Collaborator
|
@hevanaa Please add the KB to the macro IS_RGB (because that macro filters all non rgb devices) if it has no lights or add it to IS_MONOCHROME if it has monochrome LEDs (sorry, I do not know the device). You find them in usb.h |
Contributor
Author
|
I should have based this on testing, sorry. |
|
I tested and it works perfectly, thank you ;) |
|
Cross-reference to #87 |
ghost
mentioned this pull request
Contributor
Author
|
(note to myself, this PR was closed because of wrong branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here #55 (wrong place to discuss, actually), I've added the device ID for the K70 Rapidfire non-RGB. This has not been tested yet.