fix: user decorator missing roles#529
Open
aon wants to merge 62 commits into
Open
Conversation
# What ❔ Fixes passing DB SSL connection options ## Why ❔ Work around typeorm/typeorm#278 ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated.
…into zksync-os
# What ❔ Allows prividium admins to bypass prividium filters ## Why ❔ This is needed to simplify prividium deployment. ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated.
…into zksync-os
…into zksync-os
Unit Test Results 4 files ±0 259 suites ±0 12m 7s ⏱️ +15s For more details on these failures, see this check. Results for commit 7cc8cc9. ± Comparison against base commit 7b1dc58. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Fix user decorator missing roles by default. This change prevents forgetting passing the add user roles pipe. It fixes as well admins not being able to see some transactions due to this change.
Why ❔
Prevents a bug where user decorator might be used without roles.
Checklist