Skip to content

ENH: Allow arbitrary date formats - #72

Open
ludaavics wants to merge 5 commits into
matthewgilbert:masterfrom
ludaavics:maint/dates
Open

ENH: Allow arbitrary date formats#72
ludaavics wants to merge 5 commits into
matthewgilbert:masterfrom
ludaavics:maint/dates

Conversation

@ludaavics

Copy link
Copy Markdown

When generating dates dynamically I've found it tedious to convert the objects to the required format.

  • Added test cases with various date formats. All the tests pass with two exceptions, test_bulkref_two_ticker_one_field and test_bsrch. However, these tests currently fail in the main branch as well
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@matthewgilbert

matthewgilbert commented Nov 21, 2019

Copy link
Copy Markdown
Owner

Thanks @ludaavics, will review when I get some free time.

@ludaavics

Copy link
Copy Markdown
Author

hi @matthewgilbert -- just checking if you have any issue with the pr?

Thanks!

@matthewgilbert

Copy link
Copy Markdown
Owner

@ludaavics thanks for the PR. I reviewed it but I think a big change to the public facing API (even though this should be backwards compatible) is not something I want to introduce into the library at this point. I think this type of behaviour could be supported via decorators, so that is one option for supporting the behaviour in your own applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants