feat(LogViewer): UI polish, mobile guard, HH:MM:SS x-axis, start time / vehicle display#14468
Closed
DonLakeFlyer wants to merge 1 commit into
Closed
feat(LogViewer): UI polish, mobile guard, HH:MM:SS x-axis, start time / vehicle display#14468DonLakeFlyer wants to merge 1 commit into
DonLakeFlyer wants to merge 1 commit into
Conversation
…HH:MM:SS x-axis - Disable Log Viewer on Android/iOS (OOM with large log files; deferred to future major release with proper downsampling) - Display filename only (not full path) in the top toolbar - Show log start time in the toolbar using the system locale short datetime format - Show detected vehicle type in the toolbar (ArduCopter, ArduPlane, PX4, etc.) - Remove detected vehicle type from the fields panel (now shown in toolbar) - X-axis tick labels now show HH:MM:SS (elapsed) or locale-formatted local time using AbstractAxis.labelDelegate instead of the printf-only labelFormat - Add Elapsed / Local time radio buttons in the fields panel (second row); only visible when the log has a valid start time - Cursor drag: fix cursor position not updating while dragging (non-shift press) - Remove mobile-only PinchHandler dead code from LogViewerChart
Collaborator
Author
|
@AhmWael I'm not done with this but give this a try:
Probably other things I've forgotten about. I did a lot of reorganizing. I've tested this on .ulg files to verify that start time detection from gps works. |
Contributor
|
See the Build Results workflow run for details. |
Contributor
|
@DonLakeFlyer
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of UI polish improvements to the Log Viewer, plus a mobile guard to prevent OOM crashes.
Changes
Mobile guard
#if !defined(Q_OS_ANDROID) && !defined(Q_OS_IOS)inanalyzePages(). Parsing large log files (e.g. 900 MB ULog with 1000+ fields) exhausts the mobile heap. Proper mobile support requires time-bucketed downsampling and is deferred to a future major release.Toolbar improvements
ArduCopter,ArduPlane,PX4, etc.) is shown in the toolbarX-axis tick labels
HH:MM:SS/M:SS/SSsfor elapsed time, or locale-formatted local wall-clock time (h:mm:ss AP/HH:mm:ss) when local time is selectedAbstractAxis.labelDelegate(a proper QML Component), replacing theprintf-onlylabelFormat.tlogand logs without timestamps)Bug fixes
onPositionChanged)PinchHandlerdead code fromLogViewerChart