Open
Conversation
|
@obliviusm pls fix broken tests |
Contributor
|
Not sure about the issue/fix, but having a dummy Rails app to test is definitely something good to have. @modsognir What do you think if I create a new PR just to add the Rails app test for the current code in |
|
@repinel there is dummy app in this pr |
Contributor
Collaborator
|
Sorry I missed this one folks. @repinel yes, if the dummy app was split into a seperate PR that would make this one a lot easier to check over. Not sure why this is failing on 1.9.3 but I think we might be able to remove that as 1.9.3 hasn't been officially supported in 2 years. |
Contributor
|
@modsognir I can work on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Let me explain myself
Problem: New version of sprockets-rails is not compatible with princely. In new version of sprockets-rails code
Rails.application.assetsreturns assets for development environment but doesn't return assets in production-like environments.Solution: I've modified
AssetSupport#asset_file_path. So it generates the sprockets environment if it finds Rails.application.assets to be nil.This solution is taken from Compass/compass-rails#263 . They had the same problem.
In this PR I've done next:
AssetSupport#asset_file_paththat checks production environment. If you run this test with the old version ofAssetSupport#asset_file_pathyou'll see that it fails.AssetSupport#asset_file_pathas described in solutionThanks