feat(SF2.0/UpcomingDepartures): Add vehicle status to the top of the trip details section #2870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/sf2.0/ud/vehicle-status-in-trip-details
branch
from
dfe1ad4 to
c3757b1
Compare
thecristen
requested changes
Jan 7, 2026
| defstruct [ | ||
| :stops | ||
| ] | ||
|
|
Collaborator
There was a problem hiding this comment.
I recommend adding a @type spec here and to TripStop, as it'll make it clearer that stops is actually a list of TripStop
@type t :: %__MODULE__{
stops: [__MODULE__.TripStop.t()]
}
# in TripStop
@type t :: %__MODULE__{
cancelled?: boolean(),
# and the rest
}
Contributor
Author
There was a problem hiding this comment.
| @@ -0,0 +1,43 @@ | |||
| defmodule Dotcom.ScheduleFinder.TripDetails do | |||
| @moduledoc """ | |||
| A struct representing trip details, including a list of stops visited before and after | |||
Collaborator
There was a problem hiding this comment.
You technically took away the stops before/after distinction here, so this comment is a little confusing 😅
| time: PredictedSchedule.display_time(ps) | ||
| } | ||
| end) | ||
| |> Enum.sort_by(& &1.time) |
Collaborator
There was a problem hiding this comment.
|> Enum.sort_by(& &1.time, DateTime)
Collaborator
There was a problem hiding this comment.
do we need to reject timeless predictions here? 🤔
Contributor
Author
There was a problem hiding this comment.
Fixed the sorting, and added a test that I think shows that we don't need to reject timeless predictions
| do: "Now at #{stop_name}" | ||
|
|
||
| defp vehicle_message(nil), | ||
| do: "Finishing another trip" |
Collaborator
There was a problem hiding this comment.
don't forget translation here!
Contributor
Author
There was a problem hiding this comment.
Too late - I forgot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases, before on the left; after on the right.
Things to note:
Asana Ticket: [SF/UD] All Modes: Show vehicle status at the top of trip details