Integrate custom trigger shortcut with default TAB#12
Closed
hasecilu wants to merge 5 commits intomdkus:masterfrom
hasecilu:feat/integrate_custom_trigger-key
Closed
Integrate custom trigger shortcut with default TAB#12hasecilu wants to merge 5 commits intomdkus:masterfrom hasecilu:feat/integrate_custom_trigger-key
hasecilu wants to merge 5 commits intomdkus:masterfrom
hasecilu:feat/integrate_custom_trigger-key
Conversation
- Previously the custom style of the elements was hardcoded in strings. - Now the style of each element is in a file on `./Resources/style` directory. - Now it's easier for users to change styles. - Also this commit removes spaces from some lines.
- Add some docstrings - Remove extra colon/spaces - Use "not in" notation - Split long lines
The integration made by A. Bond allows to change the trigger to any valid keyboard shortcut but the only way to restore to TAB was removing the parameter that contains the new shortcut. The reason? When you press TAB with the intention to make it the shortcut instead of being taken by the QKeySequenceEdit the GUI interpreted the TAB key press as a command to pass to next element. This commit adds a checkbox to let the user override the default TAB shortcut, after changing the shortcut you can came back to TAB uncheking the checkbox. Fix #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been testing it for some hours and have not seen any problem.
Fix #3