Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #759 by making the API URL available to optional instance-aware form validations when the user explicitly provides instance configuration.
The
validate-*-formsactions keeprequiresInstance: falsebecause they can run fully offline. However, some individual validations can use the CHT instance when one is available, for example to load the CHT version and decide whether a deprecation warning applies. Before this change, running onlyvalidate-*-formswith--urlstill leftenvironment.apiUrlunset, so those optional instance validations were skipped.Approach
This PR keeps the offline path unchanged and only resolves
apiUrlwhen either:--local,--instance,--url, or--archive.That means purely offline validation commands do not call
getApiUrl, while commands such ascht --url=... validate-contact-formsnow populateenvironment.apiUrlfor optional validations. This also avoids swallowing invalid instance configuration: if the user provides instance options,getApiUrlis allowed to validate them normally.The availability check remains gated by
requiresInstance, so optional validations can receiveapiUrlwithout making the whole action require a live instance.Testing
npx eslint src/lib/main.js test/lib/main.spec.jsnpx mocha test/lib/main.spec.jsFORCE_COLOR=1 npm test(851 passing,1 pending)This PR was developed by Codex with supervision from jmtdev0.