Add support for outgoing late offers (offerless INVITE) to the SIP plugin - #3660
Open
lminiero wants to merge 3 commits into
Open
Add support for outgoing late offers (offerless INVITE) to the SIP plugin#3660lminiero wants to merge 3 commits into
lminiero wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we supported late offers (offerless INVITEs) in the SIP plugin, we only allowed them on the way in, that is when handling incoming calls from the SIP side and targetet to the WebRTC user. This pull request now adds support to the other direction as well, which means the WebRTC user can now originate an offerless INVITE via the SIP plugin.
To use the feature, the way you use the plugin changes slightly, as you need to:
late_offer: trueproperty to thecallrequest;acceptedevent, to handle an SDP offer, rather than an answer (as would normally be the case)late_ackrequest.I tested this using SIPp as a backend and it seems to be working as expected, but of course more feedback would help, so in case you're interested in the feature, please do give it a try and let us know. Notice that, while this is based on the
masterbranch, I'll backport it to0.xas well when merged.