chore: set precomp window size by platform#135
Conversation
Performance Benchmark ComparisonCompared Detailed Comparison
|
flyq
left a comment
There was a problem hiding this comment.
Other call sites still hardcode 11
After this PR, Committer::new(..., 11) still appears at:
ipa-multipoint/src/main.rs:14— benchmark binarybanderwagon/src/salt_committer.rs:55— doc commentbanderwagon/src/salt_committer.rs:519,561— tests
The test/benchmark sites are defensible (they're measuring fixed parameters), but if the centralization story matters, at least update the doc comment in salt_committer.rs:55 to mention platform::DEFAULT_PRECOMP_WINDOW_SIZE. The ipa-multipoint benchmark is your call — leave it pinned to 11 for stable measurements, or migrate it for consistency.
Updated the remaining Committer::new(..., 11) call sites to use platform::DEFAULT_PRECOMP_WINDOW_SIZE as well. This includes:
I also extended the existing correctness sweep to cover window_size = 3. |
Summary
This PR centralizes the default precomputation window size used by Committer initialization and makes it platform-aware.
The main change is:
Changes
Motivation
PRECOMP_WINDOW_SIZE is a platform tuning parameter rather than trie-local logic. Moving it into banderwagon makes the ownership clearer and avoids duplicating platform-specific configuration in salt.
This also allows zkVM to use a smaller window size without changing the default behavior on non-zkVM platforms.