Conversation
DiskArrays now owns the backend type (JuliaIO/DiskArrays.jl#313), so that it can be a member of its `DynamicBackend` sum type. We only add methods. - Type `a` in the reduction impls to resolve an ambiguity with the `::ComputeBackend` fallbacks in DiskArrays. - Tests select the backend per array with `withbackend` instead of relying on the backend preference, and import `AccessCountDiskArray` from `DiskArrays.TestTypes`. - Temporary `[sources]` entry pointing to the DiskArrays branch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ra7EAJeFE1dtekwf4Tzxh
- Qualify `Base.mapreducedim!`, size the output from `ndims` instead of assuming 3 dimensions, and start the reference from `zero(R)` instead of uninitialized memory. - `init=0.0` for float data, an Int `init` with `dims` throws in Base too. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ra7EAJeFE1dtekwf4Tzxh
- Reductions over all dimensions return a scalar like in Base, instead of the 1x...x1 array from `compute`. Same for `mapreduce` without `dims`. - `mapreduce` applied only `op` and never `f`. - Without `init`, `mapreduce` got DiskArrays' `_InitialValue` sentinel to fill the buffers with. Use a neutral element of `op` instead. - `value(::OnlineStats.Extrema)` is a NamedTuple `(min, max, nmin, nmax)`, so `maximum` with `strategy=:reduce` returned `nmax`, a count, and `extrema` failed to convert. Use the accessors of the stat. This fixes the `@test_broken` "gives all ones for some reason" in the Aggregate tests. - `extrema` defaults to `strategy=:reduce`, the direct aggregator broadcasts its result into the output, which fails for a Tuple. - Tests: scalar results for `mapreduce` without `dims`, an associative `op`, and regression tests for the OnlineStats path. - Point `[sources]` to the DiskArrays branch with the `count` fallback. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018ra7EAJeFE1dtekwf4Tzxh
Coverage Report for CI Build 35607162816Coverage increased (+4.0%) to 61.916%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.