Optimize CPU info gathering for high thread count systems#172
Open
aggifford wants to merge 1 commit intomej:masterfrom
Open
Optimize CPU info gathering for high thread count systems#172aggifford wants to merge 1 commit intomej:masterfrom
aggifford wants to merge 1 commit intomej:masterfrom
Conversation
Replaces line-by-line bash loop with grep/awk commands for processing /proc/cpuinfo, reducing execution time from 40+ seconds to <1 second on systems with 768+ threads. On high thread count systems (e.g., dual AMD EPYC with 768 threads), /proc/cpuinfo contains ~19,200 lines. The original while-loop implementation caused nhc_hw_gather_data() to timeout even with TIMEOUT=600. The optimized implementation uses grep and awk for direct value extraction, maintaining identical functionality while dramatically improving performance. Fixes mej#30
TheWitness
approved these changes
Nov 5, 2025
|
I'm having the same issue on even 288 thread zen3 servers |
|
@aggifford this is fixed in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces line-by-line bash loop with grep/awk commands for processing /proc/cpuinfo, reducing execution time from 40+ seconds to <1 second on systems with 768+ threads.
On high thread count systems (e.g., dual AMD EPYC with 768 threads), /proc/cpuinfo contains ~19,200 lines. The original while-loop implementation caused nhc_hw_gather_data() to timeout even with TIMEOUT=600.
The optimized implementation uses grep and awk for direct value extraction, maintaining identical functionality while dramatically improving performance.
Fixes #30