Clean up root configs and add CI caching#1272
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates repository developer tooling/configuration to improve cross-platform consistency and speed up CI by caching pnpm dependencies.
Changes:
- Normalize VS Code TypeScript SDK path to a cross-platform format.
- Simplify and reorganize
.gitignoreand.editorconfigsettings. - Add pnpm store caching to GitHub Actions workflows to reduce install time.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.vscode/settings.json |
Uses a cross-platform typescript.tsdk path format. |
.gitignore |
Consolidates ignores into IDE/OS/Project sections and removes older editor-specific patterns. |
.editorconfig |
Sets tab indentation by default and 2-space indentation for selected text formats. |
.github/workflows/test.yml |
Adds pnpm store caching for faster CI test installs (Playwright container). |
.github/workflows/main.yml |
Adds pnpm store caching (including Windows matrix compatibility via bash shell). |
.github/workflows/docs.yml |
Adds pnpm store caching for docs/examples build workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
.editorconfig
Outdated
| indent_style = tab | ||
|
|
||
| [**.{html,json,yml,css}] | ||
| [*.{json,yml,yaml,css,html,md}] |
- .gitignore: remove stale entries (Eclipse, Sublime, add-on/, _SpecRunner.html) - .editorconfig: add tab indent for JS/TS files, simplify - .vscode/settings.json: fix Windows path separator in typescript.tsdk Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
obiot
force-pushed
the
chore/cleanup-root-configs
branch
from
e70dea4 to
a0db7c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore: remove stale entries (Eclipse, Sublime, add-on/, _SpecRunner.html).editorconfig: add tab indent for JS/TS, simplify.vscode/settings.json: fix Windows path separator in typescript.tsdkactions/cache@v4— should save ~20-30s per run on cache hitsTest plan
🤖 Generated with Claude Code