Upgrade pnpm 9 to 10 and tighten Node.js engine requirement#1274
Merged
Upgrade pnpm 9 to 10 and tighten Node.js engine requirement#1274
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the monorepo tooling baseline to pnpm 10 and tightens Node.js engine requirements to align with Vite 8’s supported Node versions, while updating the lockfile accordingly.
Changes:
- Bumped root
packageManagertopnpm@10.32.1and tightenedengines.nodeto^20.19.0 || >=22.12.0. - Added
pnpm.onlyBuiltDependenciesallowlist to permit required dependency build/postinstall steps under pnpm 10. - Refreshed
pnpm-lock.yamlto reflect updated resolution graph (including vitest 4.1.0 and related transitive updates).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pnpm-lock.yaml |
Updated lockfile for pnpm 10 install/resolution output and refreshed dependency versions. |
packages/melonjs/package.json |
Tightened Node engine requirement for the melonjs package. |
package.json |
Set pnpm 10 as the package manager, tightened Node engine requirement, and configured onlyBuiltDependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
5
to
7
| "engines": { | ||
| "node": ">= 20" | ||
| "node": "^20.19.0 || >=22.12.0" | ||
| }, |
Comment on lines
40
to
42
| "engines": { | ||
| "node": ">= 20" | ||
| "node": "^20.19.0 || >=22.12.0" | ||
| }, |
- pnpm 9.5.0 → 10.32.1 - Node.js engines tightened to ^20.19.0 || >=22.12.0 (matching Vite 8) - Added pnpm.onlyBuiltDependencies for packages with postinstall scripts (core-js, esbuild, lefthook, playwright) — pnpm 10 blocks lifecycle scripts by default for security Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
obiot
force-pushed
the
chore/pnpm-and-node-engines
branch
from
b117d6e to
115bea4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^20.19.0 || >=22.12.0(matching Vite 8 requirement)pnpm.onlyBuiltDependenciesallowlist for packages with postinstall scripts (pnpm 10 blocks them by default)Test plan
🤖 Generated with Claude Code