Skip to content

Clean up TODO/FIXME/XXX comments across codebase#1282

Merged
obiot merged 1 commit intomasterfrom
chore/cleanup-todo-comments
Mar 19, 2026
Merged

Clean up TODO/FIXME/XXX comments across codebase#1282
obiot merged 1 commit intomasterfrom
chore/cleanup-todo-comments

Conversation

@obiot
Copy link
Member

@obiot obiot commented Mar 19, 2026

Summary

Test plan

  • All 1306 tests pass
  • TypeScript compilation passes with no errors
  • No behavioral changes — only comment cleanup and type widening

🤖 Generated with Claude Code

- Replace vague XXX comments with proper TODOs or issue references
- Accept Vector3d type in vector3d/observableVector3d rotate methods
- Remove stale TODOs for memoization (camera2d, color) and recursion (container)
- Remove resolved TODO in draggable (z is correctly preserved)
- Reference tickets for items needing future work:
  - #1180 (text offscreenCanvas)
  - #1277 (color memoization)
  - #1278 (createPattern texture leak)
  - #1279 (setAntiAlias texture filtering)
  - #1280 (texture cache overflow)
  - #1281 (atlas region refactor)
- Add .claude to .gitignore

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 19, 2026 04:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes and cleans up TODO/FIXME/XXX comments across melonJS, replacing vague inline markers with concrete issue links where appropriate, removing stale TODOs, and slightly widening the TypeScript typings for Vector3d/ObservableVector3d rotate() to explicitly accept Vector3d.

Changes:

  • Replace/remove various TODO/FIXME/XXX comments, often linking to tracked GitHub issues (#1180, #1278#1281).
  • Widen rotate() method parameter types to allow passing Vector3d explicitly.
  • Add .claude to .gitignore.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/melonjs/src/video/webgl/webgl_renderer.js Replaces inline FIXME/TODO notes with direct issue references for repeat-mode cache cleanup and anti-alias filtering behavior.
packages/melonjs/src/video/texture/cache.js Replaces a TODO with an issue link for handling texture unit exhaustion (#1280).
packages/melonjs/src/video/texture/atlas.js Replaces TODO notes with issue links related to region caching/UV lookup behavior (#1281).
packages/melonjs/src/renderable/text/text.js Replaces “XXX” note with clearer comment + issue link about OffscreenCanvas being disabled in WebGL text rendering (#1180).
packages/melonjs/src/renderable/sprite.js Replaces TODO with issue link regarding undefined entries caused by atlas coordinate caching (#1281).
packages/melonjs/src/renderable/renderable.js Replaces “XXX” with a concrete TODO describing intended absolute-position caching/invalidation.
packages/melonjs/src/renderable/draggable.js Removes stale inline TODO about z handling (no behavior change).
packages/melonjs/src/renderable/container.js Removes stale TODO about recursion in body-collection logic (no behavior change).
packages/melonjs/src/math/vector3d.ts Updates rotate() signature to accept Vector3d explicitly; clarifies param doc.
packages/melonjs/src/math/observableVector3d.ts Updates rotate() signature to accept Vector3d explicitly; clarifies param doc.
packages/melonjs/src/math/color.ts Removes stale TODOs about memoization (tracked via issue #1277).
packages/melonjs/src/level/tiled/TMXTileMap.js Replaces “XXX” comment with a clearer TODO explaining the refactor goal for object instantiation logic.
packages/melonjs/src/camera/camera2d.js Removes stale TODOs about memoization in coordinate conversion helpers.
.gitignore Ignores .claude.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@obiot obiot merged commit e6b8e56 into master Mar 19, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants