Clean up CI workflows and remove stale rollup override#1283
Merged
Conversation
- Upgrade actions/cache from v4 to v5 across all workflows - Add explicit permissions to test.yml and main.yml - Remove dead rollup override (rollup is no longer in the dependency tree) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s CI workflows (cache action version + explicit token permissions) and removes a stale Rollup pin from the root pnpm overrides, aiming to reduce CodeQL alerts and simplify dependency constraints.
Changes:
- Bump
actions/cachefromv4tov5in docs/main/test workflows. - Add explicit
permissions: contents: readtomain.ymlandtest.yml. - Remove the root
pnpm.overridesentry that pinned Rollup.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
pnpm-lock.yaml |
Intended to drop the Rollup override from lockfile overrides (but currently still present). |
package.json |
Removes the Rollup override from pnpm.overrides. |
.github/workflows/test.yml |
Adds explicit minimal permissions and upgrades cache action to v5. |
.github/workflows/main.yml |
Adds explicit minimal permissions and upgrades cache action to v5. |
.github/workflows/docs.yml |
Upgrades cache action to v5. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
7
to
13
| overrides: | ||
| minimatch@<4.0.0: 3.1.4 | ||
| minimatch@>=9.0.0 <9.0.7: 9.0.7 | ||
| ajv@<6.14.0: 6.14.0 | ||
| rollup@>=4.0.0 <4.59.0: 4.59.0 | ||
| vite: 8.0.0 | ||
| esbuild: 0.27.4 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/cachefrom v4 to v5 across all workflows (docs, main, test)permissions: { contents: read }totest.ymlandmain.yml(resolves CodeQL code-scanning alerts)rollupoverride frompackage.json(rollup is no longer in the dependency tree)Test plan
pnpm installsucceeds without rollup overridepnpm buildsucceeds🤖 Generated with Claude Code