Skip to content

Clean up CI workflows and remove stale rollup override#1283

Merged
obiot merged 2 commits intomasterfrom
chore/ci-cleanup
Mar 19, 2026
Merged

Clean up CI workflows and remove stale rollup override#1283
obiot merged 2 commits intomasterfrom
chore/ci-cleanup

Conversation

@obiot
Copy link
Member

@obiot obiot commented Mar 19, 2026

Summary

  • Upgrade actions/cache from v4 to v5 across all workflows (docs, main, test)
  • Add explicit permissions: { contents: read } to test.yml and main.yml (resolves CodeQL code-scanning alerts)
  • Remove dead rollup override from package.json (rollup is no longer in the dependency tree)

Test plan

  • pnpm install succeeds without rollup override
  • pnpm build succeeds
  • CI passes with updated actions

🤖 Generated with Claude Code

- Upgrade actions/cache from v4 to v5 across all workflows
- Add explicit permissions to test.yml and main.yml
- Remove dead rollup override (rollup is no longer in the dependency tree)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 19, 2026 06:57
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s CI workflows (cache action version + explicit token permissions) and removes a stale Rollup pin from the root pnpm overrides, aiming to reduce CodeQL alerts and simplify dependency constraints.

Changes:

  • Bump actions/cache from v4 to v5 in docs/main/test workflows.
  • Add explicit permissions: contents: read to main.yml and test.yml.
  • Remove the root pnpm.overrides entry that pinned Rollup.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pnpm-lock.yaml Intended to drop the Rollup override from lockfile overrides (but currently still present).
package.json Removes the Rollup override from pnpm.overrides.
.github/workflows/test.yml Adds explicit minimal permissions and upgrades cache action to v5.
.github/workflows/main.yml Adds explicit minimal permissions and upgrades cache action to v5.
.github/workflows/docs.yml Upgrades cache action to v5.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 7 to 13
overrides:
minimatch@<4.0.0: 3.1.4
minimatch@>=9.0.0 <9.0.7: 9.0.7
ajv@<6.14.0: 6.14.0
rollup@>=4.0.0 <4.59.0: 4.59.0
vite: 8.0.0
esbuild: 0.27.4

@obiot obiot merged commit 9efa9fc into master Mar 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants