[codex] Skip raw session recall when session save is disabled - #333
Draft
Bosn wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MNEMO_DISABLE_SESSION_SAVEso raw session rows do not participate in/memoriesrecall/list pathsmemory_type=sessionwhen the server switch is enabledWhy
Local logs showed
GET /memoriesrequests reaching client cancellation around 30s while session recall was still running despiteMNEMO_DISABLE_SESSION_SAVE=true. This keeps the switch aligned with the intended facts-only mode and makes canceled requests easier to distinguish from server failures.Validation
cd server && go test -race -count=1 ./internal/config/cd server && go test -race -count=1 ./internal/handler/cd server && go test -race -count=1 ./internal/service/