Improve session adjacent turn recall - #345
Draft
okJiang wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session_id + seqwindows around already retrieved session memories.LoCoMo evidence
20260602T104638freshbase2/Users/jiangxianjie/code/okjiang/harness/mem9-locomo/20260602T104638freshbase2/benchmark-results.jsonOverall LLM (micro):0.6448051948be522490716e2e16d961a89936a6c81e96a7a39f20260603T0155sessfull/Users/jiangxianjie/code/okjiang/harness/mem9-locomo/20260603T0155sessfull/benchmark-results.jsonOverall LLM (micro):0.6532467532+0.00844155849908dbb17c771efed6b4bd1493dbe612f8d9f00fmem9-benchmark69d0d9c8fe665259bd3234fe9d16a256af266d34/Users/jiangxianjie/code/mem9-locomo-workspace/mem9-benchmark/locomo/data/locomo10.jsonqwen3.6-plus,sessioningest, retrieval limit10, no sample/category filters,1540/1540LLM-judged rows,1986total rows.Category LLM movement:
0.38297872340.3794326241-0.00354609930.76635514020.7538940810-0.01246105920.37500000000.3958333333+0.02083333330.71700356720.7360285375+0.0190249703Cat1/Cat2 regressions were reviewed and accepted as non-blocking for this draft: Cat1 is a net
-1LLM hit, Cat2 is a net-4LLM hits, while the primary metric improves by+13/1540judged rows. Cat2 temporal/entity rows are recorded as the next follow-up risk.Local checks
gofmt -l server/internal/domain/types.go server/internal/handler/memory_test.go server/internal/repository/factory.go server/internal/repository/repository.go server/internal/repository/tidb/sessions.go server/internal/repository/tidb/sessions_test.go server/internal/service/session.go server/internal/service/session_test.go git diff --check go test ./internal/service ./internal/repository/tidb ./internal/handler go build ./cmd/mnemo-server rm -f server/mnemo-serverAll checks passed in the candidate worktree before opening this draft PR.
Benchmark integrity
The benchmark dataset, gold answers, judge prompts, judge model, scoring logic, category labels, and benchmark semantics were not changed. The candidate was evaluated with the checked-in harness runner
./locomo.sh --sample-concurrency 5 --evaluation-concurrency 8 --sample-retries 2using the same benchmark configuration as the baseline.