fix: Pin metrics format so the mg-exporter keeps receiving JSON - #285
Merged
Merged
Conversation
Contributor
Author
Tracking
Standard development
Labels checklist
Documentation checklist
|
colinbarry
force-pushed
the
fix/pin-metrics-format-for-exporter
branch
from
September 7, 2026 11:27
25b9e54 to
04d75de
Compare
as51340
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memgraph 3.13 changed the default of
--metrics-formatfromJSONtoOpenMetrics(memgraph memgraph#4678). Neither chart set the flag on themg-exporterpath, so both relied on that default; after upgrading, the exporter getsOpenMetricsit cannot parse and no metrics reach Prometheus, with--metrics-format=JSONper instance as the only workaround. Both charts now pin the format to match the scrape path they deploy, in both directions, so neither depends on the image's default.Also adds
scripts/verify-metrics-format.sh(8helm templateassertions, no cluster, wired into both lint workflows) and fixes the metrics check inverify-remote-monitoring.sh, which assertedup{job="memgraph-exporter"}: true even when the exporter parses nothing, which is why its existing mg-exporter leg passed against this bug.