feat: add AccessoriesHelper by ItsEmpa · Pull Request #159 · meowdding/SkyOcean

ItsEmpa · 2025-11-23T15:20:16Z

~~still a WIP~~ Should be good enough for now

also adds a lot of todos

github-actions · 2025-11-23T17:51:11Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

# Conflicts: # gradle/libs.versions.toml

github-actions · 2025-11-24T18:16:50Z

45 Detekt Failures

Rules flagged (9): FunctionExpressionBody, ClassOrdering, ReturnCount, NoTrailingSpaces, ExplicitItLambdaParameter, BlankLineBetweenWhenConditions, Wrapping, NoMultipleSpaces, TrailingCommaOnCallSite
Files flagged (3): AccessoriesData.kt, AccessoriesHelper.kt, AccessoriesHelperScreen.kt

Rule violations

AccessoriesData.kt#L43 FunctionExpressionBody: Function body should be replaced with body expression
AccessoriesHelper.kt#L57 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L57 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L57 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L57 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property duplicateFamilies should be declared before method declarations.
AccessoriesHelper.kt#L113 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L113 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L113 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L113 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property currentIds should be declared before method declarations.
AccessoriesHelper.kt#L184 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L184 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L184 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L184 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property displayName should be declared before method declarations.
AccessoriesHelper.kt#L186 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L186 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L186 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L186 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L31 ClassOrdering: property isEnabled should be declared before method declarations.
AccessoriesHelper.kt#L66 ReturnCount: Function getResult has 7 return statements which exceeds the limit of 5.
AccessoriesHelper.kt#L189 FunctionExpressionBody: Function body should be replaced with body expression
AccessoriesHelper.kt#L203 NoTrailingSpaces: Trailing space(s)
AccessoriesHelperScreen.kt#L264 ExplicitItLambdaParameter: it should not be used as name for a lambda parameter.
AccessoriesHelperScreen.kt#L235 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
AccessoriesHelperScreen.kt#L242 BlankLineBetweenWhenConditions: Add a blank line between all when-conditions in case at least one multiline when-condition is found in the statement
AccessoriesHelperScreen.kt#L197 FunctionExpressionBody: Function body should be replaced with body expression
AccessoriesHelperScreen.kt#L264 Wrapping: Missing newline after "("
AccessoriesHelperScreen.kt#L275 Wrapping: Missing newline before ")"
AccessoriesHelperScreen.kt#L233 NoMultipleSpaces: Unnecessary long whitespace
AccessoriesHelperScreen.kt#L201 TrailingCommaOnCallSite: Missing trailing comma before ")"
AccessoriesHelperScreen.kt#L275 TrailingCommaOnCallSite: Missing trailing comma before ")"

…at/accessories-helper

…round todos

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

…at/accessories-helper

github-actions · 2025-12-04T12:08:32Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

… without price, and more fixes fixes error when no mp is found, fixes item modifier not showing slot text, and remove ascending/descending options

# Conflicts: # gradle/libs.versions.toml

…at/accessories-helper

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

github-actions · 2026-01-27T18:47:28Z

3 Detekt Failures

Rules flagged (2): ImportOrdering, NoUnusedImports

Utils.kt#L57 ImportOrdering: Duplicate 'import tech.thatgravyboat.skyblockapi.api.item.replaceVisually' found
Utils.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end -- no autocorrection due to comments in the import list
Utils.kt#L57 NoUnusedImports: Unused import

github-actions · 2026-02-06T15:34:47Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

# Conflicts: # src/main/kotlin/me/owdding/skyocean/features/item/search/ItemSearch.kt

github-actions · 2026-02-13T12:40:50Z

1 Detekt Failure

Utils.kt#L3 ImportOrdering: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end -- no autocorrection due to comments in the import list

github-actions · 2026-02-26T09:57:18Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

# Conflicts: # detekt/1.21.11-baseline.xml # gradle/libs.versions.toml # src/main/kotlin/me/owdding/skyocean/utils/Utils.kt

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

github-actions · 2026-03-02T18:36:08Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

# Conflicts: # detekt/1.21.11-baseline.xml

github-actions · 2026-03-10T22:03:27Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

# Conflicts: # src/main/kotlin/me/owdding/skyocean/utils/Utils.kt

github-actions · 2026-04-21T23:00:49Z

This pull request has conflicts, please resolve those before the pull request can be reviewed.

…#216) Co-authored-by: Rain <niarmeowgrin@gmail.com>

ItsEmpa added 3 commits November 19, 2025 14:28

feat(AccessoriesHelper): start implementing accessories helper

cc7caf1

Merge branch 'refs/heads/main' into feat/accessories-helper

a4254be

feat(AccessoriesHelper): create item modifier and screen

8d6a942

also adds a lot of todos

github-actions Bot added the Merge Conflicts label Nov 23, 2025

ItsEmpa added 2 commits November 24, 2025 09:51

feat: add marked accessories storage, and start working on some todos

2b317ba

Merge branch 'main' into feat/accessories-helper

68afc37

# Conflicts: # gradle/libs.versions.toml

github-actions Bot removed the Merge Conflicts label Nov 24, 2025

Merge branch 'main' into feat/accessories-helper

8bacb39

github-actions Bot added the Detekt label Nov 24, 2025

ItsEmpa and others added 8 commits November 25, 2025 09:09

feat: start implementing sort modes and mp stuff

b63325f

Merge remote-tracking branch 'origin/feat/accessories-helper' into fe…

c886042

…at/accessories-helper

feat: make marked accessories be the first ones and remove done todos

d3b9c89

fix(AccessoriesHelper): fix sorting not working correctly, and move a…

35b3925

…round todos

Merge branch 'main' into feat/accessories-helper

5abcd88

feat: check unknown talismans in the repo

ec03a8f

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

Merge remote-tracking branch 'origin/feat/accessories-helper' into fe…

f6d9349

…at/accessories-helper

feat: ignore accessories from rift/bingo

b059e78

github-actions Bot added the Merge Conflicts label Dec 4, 2025

ItsEmpa and others added 3 commits December 6, 2025 14:11

feat(AccessoriesHelper): highlight marked accessories and accessories…

df1da8a

… without price, and more fixes fixes error when no mp is found, fixes item modifier not showing slot text, and remove ascending/descending options

chore: add more accessories helper todos

e42568f

Merge branch 'main' into feat/accessories-helper

5d7f104

# Conflicts: # gradle/libs.versions.toml

github-actions Bot removed the Merge Conflicts label Dec 19, 2025

j10a1n15 and others added 5 commits December 19, 2025 12:30

Merge branch 'main' into feat/accessories-helper

152b9fc

Merge branch 'main' into feat/accessories-helper

72cb947

# Conflicts: # gradle/libs.versions.toml

Merge remote-tracking branch 'origin/feat/accessories-helper' into fe…

7532782

…at/accessories-helper

chore(AccessoriesHelper): add and remove todos

e072759

feat: load mp from repo

5f80f67

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

github-actions Bot added Detekt and removed Merge Conflicts labels Jan 27, 2026

github-actions Bot added the Merge Conflicts label Feb 6, 2026

ItsEmpa added 2 commits February 13, 2026 13:27

Merge branch 'main' into feat/accessories-helper

8496918

# Conflicts: # src/main/kotlin/me/owdding/skyocean/features/item/search/ItemSearch.kt

chore: fix detekt and changes

ff4810c

ItsEmpa requested a review from j10a1n15 February 13, 2026 12:36

github-actions Bot removed the Merge Conflicts label Feb 13, 2026

ItsEmpa requested a review from meowora February 13, 2026 12:36

j10a1n15 approved these changes Feb 13, 2026

View reviewed changes

github-actions Bot added the Merge Conflicts label Feb 26, 2026

Merge branch 'main' into feat/accessories-helper

16faa52

# Conflicts: # detekt/1.21.11-baseline.xml # gradle/libs.versions.toml # src/main/kotlin/me/owdding/skyocean/utils/Utils.kt

github-actions Bot removed the Merge Conflicts label Feb 27, 2026

docs: feature list update + cleanup

a1f57b0

Signed-off-by: J10a1n15 <45315647+j10a1n15@users.noreply.github.com>

github-actions Bot added the Merge Conflicts label Mar 2, 2026

Merge branch 'main' into feat/accessories-helper

868b8a5

# Conflicts: # detekt/1.21.11-baseline.xml

github-actions Bot removed the Merge Conflicts label Mar 3, 2026

fix: Enum next function conflicting

0fc4d89

github-actions Bot removed the Detekt label Mar 3, 2026

github-actions Bot added the Merge Conflicts label Mar 10, 2026

Merge branch 'main' into feat/accessories-helper

d75212a

# Conflicts: # src/main/kotlin/me/owdding/skyocean/utils/Utils.kt

github-actions Bot removed the Merge Conflicts label Apr 1, 2026

github-actions Bot added the Merge Conflicts label Apr 21, 2026

add 26.1 stonecutter thingy and rename forbiddenImports in detekt.yml (…

013b569

…#216) Co-authored-by: Rain <niarmeowgrin@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add AccessoriesHelper#159

feat: add AccessoriesHelper#159
ItsEmpa wants to merge 40 commits into
mainfrom
feat/accessories-helper

ItsEmpa commented Nov 23, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 23, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Dec 4, 2025

Uh oh!

github-actions Bot commented Jan 27, 2026

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

github-actions Bot commented Feb 13, 2026

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Mar 2, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ItsEmpa commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 23, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

45 Detekt Failures

Uh oh!

github-actions Bot commented Dec 4, 2025

Uh oh!

github-actions Bot commented Jan 27, 2026

3 Detekt Failures

Uh oh!

github-actions Bot commented Feb 6, 2026

Uh oh!

github-actions Bot commented Feb 13, 2026

1 Detekt Failure

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

github-actions Bot commented Mar 2, 2026

Uh oh!

github-actions Bot commented Mar 10, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ItsEmpa commented Nov 23, 2025 •

edited

Loading