Add support for general CSR(A) x CSR(B) sparse matrix multiplication#22
Open
Saptami191 wants to merge 1 commit into
Open
Add support for general CSR(A) x CSR(B) sparse matrix multiplication#22Saptami191 wants to merge 1 commit into
Saptami191 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
Summary
This PR adds support for general CSR(A) × CSR(B) sparse matrix multiplication instead of assuming self-multiplication (
A × A).The current implementation in
AxBRowIP.cloaded the same CSR files for both matrices and reused the same dimension metadata, which restricted the kernel to square self-multiplication workloads and caused incorrect handling for general rectangular SpGEMM cases.Changes
General SpGEMM Support
M,K,N)aNNZ,bNNZ)Dimension & Correctness Fixes
NbNNZNinstead ofKCOO → CSR Improvements
Test Matrices
Added:
for reproducible validation and testing.
Validation
Tested successfully on:
Verified example:
[
(2 \times 3) \times (3 \times 4)
\rightarrow (2 \times 4)
]
Example runtime output: