Skip to content

Conversation

@yuxuan-z19
Copy link
Contributor

@yuxuan-z19 yuxuan-z19 commented Nov 28, 2025

Currently, installation scripts always invoke pip via sys.executable -m pip in subprocesses.
This PR introduces get_pip_cmd() (same as PR#2659 for torchbench), which:

  • Uses the PIP_MODULE environment variable to override the installer if set.

    PIP_MODULE="uv pip" python install.py
  • Defaults to sys.executable -m pip otherwise.

@meta-cla meta-cla bot added the cla signed label Nov 28, 2025
@xuzhao9
Copy link
Contributor

xuzhao9 commented Nov 28, 2025

Thanks for the contribution. Unfortunately, our build environment is not ready for uv yet, even when uv is available.

The main blocker is that we need conda env clone to construct and hot-switch multiple environments with the default pytorch triton, triton-main, and meta's triton fork. Right now, uv does not support multiple environments for single project.

We can accept the env PIP_MODULE, but we need to use sys.executable -m pip otherwise.

@yuxuan-z19
Copy link
Contributor Author

yuxuan-z19 commented Nov 29, 2025

Got it @xuzhao9! I’ve removed the uv fallback, so the installer now only honors PIP_MODULE when provided and otherwise falls back to sys.executable -m pip. Could you take a look and let me know if this aligns with what you had in mind?

@xuzhao9
Copy link
Contributor

xuzhao9 commented Dec 1, 2025

LGTM

@xuzhao9 xuzhao9 self-requested a review December 1, 2025 14:57
@xuzhao9 xuzhao9 merged commit 278cc90 into meta-pytorch:main Dec 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants