Skip to content

docs: fix the dead Eta syntax link in the config reference - #13066

Open
farisbasha wants to merge 1 commit into
meta:mainfrom
farisbasha:docs/fix-eta-link
Open

farisbasha wants to merge 1 commit into
meta:mainfrom
farisbasha:docs/fix-eta-link

Conversation

@farisbasha

@farisbasha farisbasha commented Nov 16, 2026 •

Copy link
Copy Markdown

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Not a code change (one documentation link).
  • Not a new API or substantial change.

Motivation

In website/docs/api/docusaurus.config.js.mdx, the ssrTemplate option links to Eta's syntax docs at https://eta.js.org/docs/syntax#syntax-overview, which returns 404 since the Eta site moved to versioned docs. Docusaurus depends on Eta ^4.6.0 (see pnpm-workspace.yaml), so the link now points to the matching 4.x page, https://eta.js.org/docs/4.x.x/syntax/template-syntax.

Test Plan

Checked with curl: the old URL returns 404; the new URL returns 200 and its title is "Template Syntax | Eta". No code change; the site build was not run locally.

Test links

Docs page changed: https://docusaurus.io/docs/api/docusaurus-config (ssrTemplate).

AI disclosure: this change was prepared with the help of an AI coding agent (Claude) and verified as described above.

Summary by CodeRabbit

  • Documentation
    • Updated the ssgTemplate documentation link to point to the Eta 4.x template syntax reference.

@meta-cla

meta-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

Hi @farisbasha!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The ssgTemplate description now links to the Eta 4.x syntax documentation instead of the previous syntax overview URL.

Changes: Eta syntax documentation

Layer / File(s) Summary
Update Eta syntax reference
website/docs/api/docusaurus.config.js.mdx
The ssgTemplate description links to the Eta 4.x syntax documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested labels: pr: documentation

Merge Risk: Minimal · up to dbbec

This is a documentation-only link fix that points readers to the correct Eta 4.x syntax page. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "docs: fix the dead Eta syntax link in the config reference" matches the change. The PR updates the Eta syntax link in website/docs/api/docusaurus.config.js.mdx, which the author reports ret…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "docs: fix the dead Eta syntax link in the config reference" matches the change. The PR updates the Eta syntax link in website/docs/api/docusaurus.config.js.mdx, which the author reports returns 404, to the Eta 4.x template syntax page. The title names the main change and the affected file area. It is specific and concise.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b5d34197-0e60-404a-a277-3770a934eee9
Commits

Reviewing files that changed from the base of the PR and between 4c4ec4a and dbbec67.

Files selected for processing: 1

  • website/docs/api/docusaurus.config.js.mdx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@netlify

netlify Bot commented Nov 16, 2026

Copy link
Copy Markdown

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit dbbec67
🔍 Latest deploy log https://app.netlify.com/projects/docusaurus-2/deploys/6afb6dbd3ba3d223618763fc
😎 Deploy Preview https://deploy-preview-13066--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@meta-cla meta-cla Bot added the CLA Signed Signed Facebook CLA label Nov 17, 2026
@meta-cla

meta-cla Bot commented Nov 17, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant