test: add confDir test and fix linting in integration spec#184
test: add confDir test and fix linting in integration spec#184viferga merged 7 commits intometacall:masterfrom
Conversation
|
@p4rthh I just checked the test and the flag --confDir is not being tested. The test should be something like this: deploy/src/test/cli.integration.spec.ts Line 53 in b58283b The test in general is good, specially the |
|
If you test like you are doing, you skip the whole purpose of testing --confDir like in here: Line 20 in b58283b
|
|
@p4rthh I have done two more changes, I have restored exactly how the TODO comments were before. It's important to be atomic whenever possible and don't change things in a commit that are unrelated, even if it is just spaces and nothing changed. The other thing I have changed is the writeFileSync, I made it async. I am going to squash the commits into one but you can check the final code to see the differences. |
|
@p4rthh your PR broke the CI in production: |
Description
This PR adds an integration test for the
--confDirflag (src/test/confDir.spec.ts).Changes
src/test/confDir.spec.tsto verify the flag functionality.npm run fixtosrc/test/cli.integration.spec.tsto resolve upstream linter errors (Tabs vs Spaces) as discussed in Discord.Notes
The
cli.integration.spec.tslogic remains unchanged; only formatting was updated to pass the linter.