Update phace - #1212
Closed
ppegolo wants to merge 5 commits into
Closed
Conversation
Contributor
|
peace has been deprecated :( |
Contributor
You can only find peace in space |
Contributor
|
So, apart from the renaming it is only the fine-tuning that has been modified? |
pfebrer
approved these changes
Jul 22, 2026
Contributor
|
Ok I see there was also something on the CG coefficients |
Contributor
Author
|
Yes, it's a port of some features that Filippo had in a branch that completely diverged from main. Plus the finetuning, and plus the rename |
pfebrer
reviewed
Jul 22, 2026
| @@ -12,6 +12,18 @@ | |||
| from .tensor_product import couple_features_all, uncouple_features_all | |||
|
|
|||
|
|
|||
| def _make_k_max_l( | |||
| n_max: List[int], n_channels: int, force_rectangular: bool | |||
| ) -> List[int]: | |||
Contributor
There was a problem hiding this comment.
Well actually some explanation of what this function does could be useful probably hahah
ppegolo
force-pushed
the
phace-update
branch
2 times, most recently
from
July 22, 2026 14:43
c150659 to
4f8de09
Compare
Contributor
Author
|
cscs-ci run |
1 similar comment
Contributor
Author
|
cscs-ci run |
Contributor
Author
|
cscs-ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the
phace-large-scale-2updates to main.Moreover, this PR renames
phacetospace.The name has been changed also in the test checkpoints metadata. No trace of
phaceis left in the repo, apart from mentions in commit messages and the changelog. This is because the architecture is experimental and unpublished, so in principle there's not need to formally deprecate it. SInce there are some internal checkpoints that might still need updating, here's a script to do so: migrate_phace_checkpoints.pyContributor (creator of pull-request) checklist
Maintainer/Reviewer checklist
📚 Documentation preview 📚: https://metatrain--1212.org.readthedocs.build/en/1212/