Open
Conversation
Merge branches ahead of step 2
…merge-tech-debt-migrate_to_uv tech debt merge
peterrrock2
reviewed
Mar 26, 2026
Collaborator
peterrrock2
left a comment
peterrrock2
left a comment
There was a problem hiding this comment.
If we could get an overleaf document with the details of the internals for the calibration step, that would help out a ton with maintaining this long-term!
Collaborator
|
Adding a note here to change the target of this PR to feat/meek-stv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 2 out of 3 addressing issue #317.
This is a (functional) first pass at a fast implementation of Meek STV using numpy machinery. This PR also currently has a functional test suite (to which I might eventually add another few tests).
The main thing that is missing from this PR is a backup version of the algorithm that doesn't build a full permutation matrix when m and/or L are too large. I have plans for how this should be done, but I want to make sure Peter has a look at what is currently here before proceeding.