fix: Add more permissions configuration across pipelines - #31
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to explicit least-privilege workflow permissions and align with the jobs’ actual token needs.
Pull request overview
This PR tightens GitHub Actions security by explicitly setting least-privilege GITHUB_TOKEN permissions for the Unit and CI workflows, ensuring they only have repository read access unless a job explicitly needs more.
Changes:
- Add workflow-level
permissions: contents: readto the reusable Unit workflow. - Add workflow-level
permissions: contents: readto Ubuntu and macOS CI workflows. - Grant the
changesjob in Ubuntu/macOS CIpull-requests: read(in addition tocontents: read) to support PR file filtering.
File summaries
| File | Description |
|---|---|
| .github/workflows/unit.yml | Restricts reusable unit-test workflow token permissions to read-only repository contents. |
| .github/workflows/ci-ubuntu.yml | Sets read-only default permissions and scopes PR read access to the changes job. |
| .github/workflows/ci-macos.yml | Sets read-only default permissions and scopes PR read access to the changes job. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.