PVCAM: Removed polling for acquisition state#941
Merged
Conversation
Polling doesn't work reliably with recent fast cameras. Registering an EOF callback handler is the recommended way for many years already. Removed all logic related to polling, including a property for selecting between polling and callbacks.
…end. When running live acquisition with circular buffer mode disabled, the auto-shutter stayed open at the acquisition end. This has been also reported in PR 907, but the fix has not been merged (yet).
The FrameAcquired() function locks acqLock_. Any error in here or nested call would cause a deadlock by calling StopSequenceAcquisition(). Switched to abortAcquisitionInternal() that doesn't lock and done that on a few exit points only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polling doesn't work reliably with recent fast cameras. Registering an EOF callback handler is the recommended way for many years already. Removed all the logic related to polling, including a property for selecting between polling and callbacks.
As a side change I have fixed auto-shutter that was not always closed at the acquisition end, because it was inside modified code. This has been reported and fix proposed in PR #907.