[Event Request] Codeunit 22 "Item Jnl.-Post Line" - Function PostOutput()

[MirenToledo]

Why do you need this change?

We need to create Prod. Orders for Items not in inventory ("Inventory Value Zero" = true) because they are not items to be sold. The customer creates this items for testing purposes and they don't want to have that extra value on inventory. Therefore, we need to avoid the TestField statement.

Describe the request

In codeunit 22, function PostOutput(), new event before "Inventory Value Zero" TestField.

local procedure PostOutput()
var
   (...)
begin
    
    (...)

    if ItemJnlLine.Subcontracting then
        ValuedQty := ItemJnlLine."Invoiced Quantity"
    else
        ValuedQty := CalcCapQty();

NEW CODE ---->
IsHandled := false;
OnPostOutputOnBeforeGetItem(ItemJnlLine, IsHandled);
if not IsHandled then
NEW CODE <----

    if GetItem(ItemJnlLine."Item No.", false) then
        if not CalledFromAdjustment then
            Item.TestField("Inventory Value Zero", false);

    if ItemJnlLine."Item Shpt. Entry No." <> 0 then
        CapLedgEntry.Get(ItemJnlLine."Item Shpt. Entry No.")
    else
        PostOutputForProdOrder(ProdOrder, ProdOrderLine, CapLedgEntry, ValuedQty, LastOperation);

    CalcDirAndIndirCostAmts(DirCostAmt, IndirCostAmt, ValuedQty, ItemJnlLine);

Internal work item: AB#610210

[AleksandricMarko]

Hello Miren Toledo (@MirenToledo)
Recently we announced that for every new IsHandled event request, author need to provide a response to several question (please check link)

We want to be sure that IsHandled event is the only option, as this kind of events is not the best approach due to several reasons (codebase harder to maintain, harder refactoring, fragile solutions, easily break other implementations...)

Please also check the explanation about when and how to use IsHandled events (link)

[MirenToledo]

As requested, I'll add here all the minimum requested information:

1. Problem statement: Our customer is a biopharmaceutical company dedicated to the development, manufacture and marketing of drugs for the treatment of cancer. The development of a product to reach the market takes between 10-20 years. In the life cycle of a product, two phases are distinguished:

• INVESTIGATIONAL PRODUCT (R+D): Products in development that have not yet been approved by regulatory agencies.
• MARKETED PRODUCT: Product that has been approved for marketing by regulatory agencies.

Pharmaceutical products are manufactured under highly controlled conditions (GXP), whether they are RESEARCH or COMMERCIALIZED. The manufacturing routes are complex and supervised in detail by the Quality Department. The distribution process is controlled and with full end-to-end traceability whether they are RESEARCH or COMMERCIALIZED. From an accounting point of view, the products under INVESTIGATION are configured as "zero value" stocks (see details below). From a shipping point of view, products under INVESTIGATION are shipped (at zero sales price) to hospitals participating in clinical trials.

Details on "zero value" stocks
• According to the General Accounting Plan, only those products intended for sale or capable of generating future cash flows can be included under the Inventory heading (Royal Decree 1514/2007, of 16 November, NRV 10a).
• Stocks linked to R+D– such as Aplidine, PM14, PM54, PM534, etc. – or their intermediates or the reagents used to manufacture them do not meet this criterion until they are approved by the Health Authorities. Although they exist physically and require logistical control (inputs via purchase or manufacturing and outputs for clinical trials, for example), they must remain as an expense, not as an asset on the company's balance sheet.

The "Inventory Value Zero Value" option allows the ERP to reflect this treatment:
• In purchasing or manufacturing, all products generate the usual expense entry.
• In the monthly change of stocks, only items NOT marked as Inventory Value Zero are activated on the balance sheet.
• Thus, those marked as Inventory Value Zero are correctly kept in expense.

2. Proposed code change:
   In Codeunit 99000822 - Mfg. Item Jnl.-Post Line, function PostOutput add the following:

    if ItemJnlLine.OutputValuePosting() then begin
        sender.PostItem(ItemJnlLine);
        exit;
    end;
   
    if ItemJnlLine.Subcontracting then
        ValuedQty := ItemJnlLine."Invoiced Quantity"
    else
        ValuedQty := CalcCapQty(ItemJnlLine);
   

NEW CODE ---->
IsHandled := false;
OnPostOutputOnBeforeTestInventoryValueZero(ItemJnlLine, IsHandled);
if not IsHandled then
NEW CODE <----

    if GetItem(ItemJnlLine."Item No.", false) then
        if not sender.GetCalledFromAdjustment() then
            Item.TestField("Inventory Value Zero", false);

    if ItemJnlLine."Item Shpt. Entry No." <> 0 then
        CapLedgEntry.Get(ItemJnlLine."Item Shpt. Entry No.")
    else
        PostOutputForProdOrder(
            ItemJnlLine, ProdOrder, ProdOrderLine, CapLedgEntry, ValuedQty, LastOperation,
            GlobalItemTrackingSetup, GlobalItemTrackingCode, sender);


// Event signature:
[IntegrationEvent(false, false)]
local procedure OnPostOutputOnBeforeTestInventoryValueZero(ItemJournalLine: Record "Item Journal Line"; var IsHandled: Boolean)
begin
end;

3. Invocation example:

   [EventSubscriber(ObjectType::Codeunit, Codeunit::"Mfg. Item Jnl.-Post Line", 'OnPostOutputOnBeforeTestInventoryValueZero', '', true, true)]
   local procedure Handle_OnPostOutputOnBeforeTestInventoryValueZero(ItemJournalLine: Record "Item Journal Line"; var IsHandled: Boolean)
   begin
   IsHandled := true;
   end;

4. Alternatives evaluated: There's no other alternative. The problem is just the Testfield that the system is doing and the only way is to skip it.

5. Justification for IsHandled: We need to skip the Testfield statement and the way to do it is by an IsHandled event where we won't do nothing but skipping the instruction.

6. Performance considerations: This code will be executed for each item posting, but we'll just skip the Testfield without adding any additional code in the Handle function, so the posting process will not be overcharged with more functionality.

7. Data sensitivity review: No sensitive data is exposed.

[AleksandricMarko]

Hello Miren Toledo (@MirenToledo)
Same like for the issue #29283 would it be enough to just skip testfield?

[MirenToledo]

Hello Marko Aleksandric (@AleksandricMarko)

Same answer than for issue #29283. Your proposal would be enough.

[MirenToledo]

Hello Marko Aleksandric (@AleksandricMarko)
Could you please update me the state of this task? Is there any aproximate prevision of when would it pass to the next step? Thanks in advance.

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 46093.

[MirenToledo]

Hello Jesper Schulz-Wedde (@JesperSchulz),
We tested the changes done and it partially works, but unfortunately there are another 2 places into the code where the instruction Item.Testfield("Inventory Value Zero", false) is done and it prevents working with these type of items.

1. codeunit 99000762 "Mfg. Item Journal Mgt." - procedure OnValidateItemNoOnAfterValidateUnitofMeasureCode
2. table 83 "Item Journal Line" - "Item No." - trigger OnValidate()

We didn't notice these 2 cases when we requested the change, but now that we're conducting the initial tests, we've realized it.

Would it be possible to make the same change also to these two objects in a short amount of time?

Thank you in advance.