Event request [W1][Codeunit][816]["Purch. Post Invoice"] OnSplitFAOnBeforeGenJnlPostLine event

[Katarina-BS]

Why do you need this change?

We have additional amounts in the "Gen. Journal Line" table that need to be divided when creating multiple FA cards on a purchase invoice.

Describe the request

We suggest new event OnSplitFAOnBeforeGenJnlPostLine in the SplitFA procedure.

...
        CalcSplitAmount(
            GenJnlLine."VAT Difference", GenJnlLine2."VAT Difference", TotalGenJnlLine."VAT Difference", I, SplitNo);
        CalcSplitAmount(
            GenJnlLine."Salvage Value", GenJnlLine2."Salvage Value", TotalGenJnlLine."Salvage Value", I, SplitNo);

        //new integration event
        OnSplitFAOnBeforeGenJnlPostLine(GenJnlLine, GenJnlLine2, TotalGenJnlLine, I, SplitNo);

        RunGenJnlPostLine(GenJnlLine, GenJnlPostLine);
    end;
end;
...
[IntegrationEvent(false, false)]
local procedure OnSplitFAOnBeforeGenJnlPostLine(var GenJnlLine: Record "Gen. Journal Line"; var GenJnlLine2: Record "Gen. Journal Line"; var TotalGenJnlLine: Record "Gen. Journal Line"; I: Integer; SplitNo: Integer)
begin
end;

Internal work item: AB#626298

[AleksandricMarko]

Hi Katarina-BS,

Thanks for submitting this extensibility request. To help us process it efficiently, please update the issue to include the required information.

📚 Extensibility Guidelines

⚠️ Event Placement Inside Loop - Performance Consideration Required

The proposed event OnSplitFAOnBeforeGenJnlPostLine will be placed inside a for I := 1 to SplitNo do loop in the SplitFA procedure.

Performance Impact:

• The event will fire on EVERY iteration of the loop (once for each Fixed Asset being created)
• If subscribers perform database operations, calculations, or external calls, this can cause significant performance degradation
• Performance degrades linearly with the number of FA cards being created (e.g., 10 FA cards = 10 event invocations)

Before proceeding, please provide clarification:

1. Why must the event fire on each iteration? Can you explain why you need to process each FA split individually rather than before/after the loop?

2. What operations will subscribers perform? Please describe what you plan to do in the event subscriber (e.g., simple field assignments, database lookups, complex calculations).

3. Have you considered alternatives? Would an event before the loop (to set up your data) or after the loop (for post-processing) work for your scenario?

Your Use Case:
You mentioned: "We have additional amounts in the Gen. Journal Line table that need to be divided when creating multiple FA cards."

This suggests you need to call CalcSplitAmount for your custom fields similar to how standard fields are split. If this is lightweight field assignment similar to the existing CalcSplitAmount calls, please confirm this is the case and that you understand the event fires once per FA card created.

Current Loop Structure:

for I := 1 to SplitNo do begin
    // Multiple CalcSplitAmount calls for standard fields
    CalcSplitAmount(GenJnlLine."Salvage Value", GenJnlLine2."Salvage Value", TotalGenJnlLine."Salvage Value", I, SplitNo);
    
    // Your proposed event would fire here (once per iteration)
    OnSplitFAOnBeforeGenJnlPostLine(GenJnlLine, GenJnlLine2, TotalGenJnlLine, I, SplitNo);
    
    RunGenJnlPostLine(GenJnlLine, GenJnlPostLine);
end;

Please respond with the requested clarifications so we can proceed with the implementation.

[Katarina-BS]

We will execute exactly the same operations as in CalcSplitAmount. We would call this procedure if it were public.
As far as I was able to analyze code we need this event inside the loop, there is no other alternative,

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new integration event OnSplitFAOnBeforeGenJnlPostLine in the SplitFA procedure of Codeunit 816 "Purch. Post Invoice" before RunGenJnlPostLine in the loop.

Location in SplitFA procedure (around line 1233):

        CalcSplitAmount(
            GenJnlLine."VAT Difference", GenJnlLine2."VAT Difference", TotalGenJnlLine."VAT Difference", I, SplitNo);
        CalcSplitAmount(
            GenJnlLine."Salvage Value", GenJnlLine2."Salvage Value", TotalGenJnlLine."Salvage Value", I, SplitNo);

        OnSplitFAOnBeforeGenJnlPostLine(GenJnlLine, GenJnlLine2, TotalGenJnlLine, I, SplitNo);  // <-- New event

        RunGenJnlPostLine(GenJnlLine, GenJnlPostLine);

Event Publisher (add at the end of the codeunit with other events):

[IntegrationEvent(false, false)]
local procedure OnSplitFAOnBeforeGenJnlPostLine(var GenJnlLine: Record "Gen. Journal Line"; var GenJnlLine2: Record "Gen. Journal Line"; var TotalGenJnlLine: Record "Gen. Journal Line"; I: Integer; SplitNo: Integer)
begin
end;

---

File: PurchPostInvoice.Codeunit.al

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 48589.