[Event Request] OnQueryClosePage on page 7005 "Price List Line Review"

[mortenseifert]

Why do you need this change?

When working with Price Lists (sales and purchase) and you change a line you cannot lease the page before accepting the changes. Makes sense to warn the user that the price change is not active.

However, if another user opens the price/discount lines from an item/customer/vendor etc. and draft lines are shown, the page cannot be closed. I think the use case is assuming that the same user make the change - but the draft line may just as well be due to another user making changes to a price list. Having the user approve draft lines created by someone else is very confusing.

Adding the same event we have on the sales/purchase price list to the page 7005 "Price List Line Review" will allow us work around the problem until better handling is added to the feature.

Describe the request

On page 7005 "Price List Line Review" the IsHandled pattern should be added to the OnQueryClosePage trigger.

        IsHandled := false;
        OnQueryClosePageOnBeforeDraftLineCheck(Rec, Result, IsHandled);
        if IsHandled then
            exit(Result);

Internal work item: AB#630375

[AleksandricMarko]

✅ Analysis complete - approved for implementation

---

Implementation:

Add a new IsHandled integration event in the OnQueryClosePage trigger of Price List Line Review before the draft-line check, aligned with the existing pattern already used on the sales and purchase price list pages.

Location in OnQueryClosePage() trigger (around line 401):

    trigger OnQueryClosePage(CloseAction: Action): Boolean;
    var
        PriceListManagement: Codeunit "Price List Management";
        IsHandled: Boolean;
        Result: Boolean;
    begin
        IsHandled := false;
        OnQueryClosePageOnBeforeDraftLineCheck(Rec, Result, IsHandled);
        if IsHandled then
            exit(Result);

        if HasDraftLines() then begin
            PriceListManagement.SendVerifyLinesNotification();
            exit(false);
        end;
        exit(true)
    end;

Event Publisher (add at the end of the page with other events):

    [IntegrationEvent(false, false)]
    local procedure OnQueryClosePageOnBeforeDraftLineCheck(var PriceListLine: Record "Price List Line"; var Result: Boolean; var IsHandled: Boolean)
    begin
    end;

---

File: PriceListLineReview.Page.al

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 49241.