Skip to content

refactor: dev to main - Improve search index deletion logic and handling #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Roopan-Microsoft merged 6 commits into from
Jun 1, 2026
+9 −1
Merged

refactor: dev to main - Improve search index deletion logic and handling #937

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7ffba3a
fix: delete existing search index before creation
Pavan-Microsoft May 27, 2026
589fc8b
fix: handle existing search index deletion more gracefully
Pavan-Microsoft May 27, 2026
145c6ef
fix: improve existing search index deletion logic
Pavan-Microsoft May 27, 2026
138ea78
fix: delete existing search index before creation
Avijit-Microsoft May 27, 2026
a64d3d0
fix: improve search index deletion feedback when not found
Pavan-Microsoft May 29, 2026
62502bd
fix: code quality comment - improve search index deletion feedback wh…
Avijit-Microsoft May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion infra/scripts/index_scripts/01_create_search_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
VectorSearch,
VectorSearchProfile,
)
from azure.core.exceptions import ResourceNotFoundError

# Get parameters from command line
p = argparse.ArgumentParser()
Expand Down Expand Up @@ -94,6 +95,13 @@ def create_search_index():
# Create the semantic settings with the configuration
semantic_search = SemanticSearch(configurations=[semantic_config])

# Delete the index if it already exists
try:
index_client.delete_index(INDEX_NAME)
print(f"✗ Existing search index '{INDEX_NAME}' deleted")
except ResourceNotFoundError:
Comment thread
github-code-quality[bot] marked this conversation as resolved.
Fixed
print(f"- Search index '{INDEX_NAME}' not found; skipping delete")
Comment thread
Pavan-Microsoft marked this conversation as resolved.

# Define and create the index
index = SearchIndex(
name=INDEX_NAME,
Expand All @@ -102,7 +110,7 @@ def create_search_index():
semantic_search=semantic_search
)

result = index_client.create_or_update_index(index)
result = index_client.create_index(index)
print(f"✓ Search index '{result.name}' created")


Expand Down
Loading