chore: dev to main merge#957
Merged
Merged
Conversation
…t Understanding, OpenAI, and Agent operations. Wrapped the entire processing pipeline in an async main() entry point.
fix: Failing to delete multiple chat history together bug
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the two Content Understanding processing scripts to centralize Azure credential usage and run everything under a single async main() entrypoint, and it improves the frontend “clear all chat history” behavior by falling back to paginated single-deletes when the bulk delete endpoint is missing.
Changes:
- Updated
historyListto support alimitparameter and added a 404-only fallback path inhistoryDeleteAllthat lists conversations in pages and deletes them individually. - Refactored
03_cu_process_data_text.pyand04_cu_process_custom_data.pyto reuse a sharedAzureCliCredential, consolidate async execution undermain(), and add credential cleanup.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/App/src/api/api.ts | Adds pagination support to history listing and a bulk-delete fallback to make “Clear All” more resilient across deployments. |
| infra/scripts/index_scripts/03_cu_process_data_text.py | Restructures the text processing script into an async main() and reuses a shared Azure CLI credential across clients. |
| infra/scripts/index_scripts/04_cu_process_custom_data.py | Restructures the custom data processing script similarly, including shared credentials and async orchestration for agent usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fix: Update aiohttp and pypdf versions in requirements files
Contributor
Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
fix: updated roleDefinitionIdOrName to use GUID and fixed CodeQL issue.
Roopan-Microsoft
approved these changes
Jun 16, 2026
Avijit-Microsoft
approved these changes
Jun 16, 2026
Contributor
|
🎉 This PR is included in version 3.23.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request refactors two Python data processing scripts (
03_cu_process_data_text.pyand04_cu_process_custom_data.py) and improves the chat history deletion logic in the frontend API (api.ts). The main goals are to streamline credential management, improve async handling, and make the "clear all chat history" feature more robust against missing API endpoints.Credential and async handling improvements:
Refactored both
03_cu_process_data_text.pyand04_cu_process_custom_data.pyto use a single sharedAzureCliCredentialinstance for all Azure service clients, reducing redundant instantiations and ensuring credentials are properly closed at the end of execution. All async code is now run within anasync main()function, usingasyncio.run(main())as the entry point. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Removed redundant or unnecessary credential instantiations and simplified agent creation/deletion by reusing credentials and ensuring proper cleanup with
close()calls and exception handling. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Frontend API improvements:
Enhanced the
historyDeleteAllmethod inapi.tsto fall back to paginated single-deletes if the bulk delete endpoint (/history/delete_all) is missing (e.g., returns 404), ensuring the "Clear All" feature works reliably across different deployments. The fallback fetches conversation IDs in pages and deletes them individually, with error handling for partial failures.Updated the
historyListfunction to accept alimitparameter for paginated fetching, supporting the fallback logic inhistoryDeleteAll.Other code cleanup:
03_cu_process_data_text.pyfor clarity.These changes improve reliability, maintainability, and resource management across both backend data processing and frontend chat history operations.
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation