FIX: validate SneakyBits marker characters - #2554
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
FIX: validate SneakyBits marker characters#2554Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SneakyBitsSmugglerConverteraccepts customzero_charandone_charmarker strings, but encoding and decoding require each marker to be exactly one character and require the two markers to be distinct.Multi-character markers are emitted as multiple code points and cannot round-trip reliably; they can also make
_build_identifier()fail when it callsord(). Identical markers make binary 0 and 1 indistinguishable and silently corrupt decoded output.This change validates both invariants during initialization and raises a clear
ValueErrorfor invalid marker configuration.Tests
Adds regression coverage for empty or multi-character markers and identical zero/one markers.