FIX: validate UnicodeSubstitution output code points - #2559
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UnicodeSubstitutionConvertercomputes each encoded character withchr(start_value + ord(character))without validating the resulting Unicode code point.Invalid configuration values or a valid high
start_valuecombined with an input character can therefore leak Python's low-levelchr() arg not in range(0x110000)exception from conversion.This change validates the configured starting value and checks each derived code point before conversion, raising a clear
ValueErrorwhen the requested substitution would fall outside the Unicode range.Tests
Adds regression coverage for invalid start values and for a valid start value whose offset would overflow for the input character.