FIX: validate VariationSelectorSmuggler base character - #2562
Open
Sylvester Kaczmarek (sylvesterkaczmarek) wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VariationSelectorSmugglerConverteraccepts any string forbase_char_utf8, but the encoding format treats the value as a single Unicode base character andencode_message()callsord()on it.Empty or multi-character values therefore construct successfully and fail later during conversion with a
TypeError.This change validates
base_char_utf8during initialization and raises a clearValueErrorunless it contains exactly one Unicode character.Tests
Adds regression coverage for empty and multi-character base values and preserves valid single-character custom bases.