FIX: restore keyboard focus to launch button on preview dismissal (#2680) - #2686
Merged
Roman Lutz (romanlutz) merged 3 commits intoSep 22, 2026
Conversation
…missal (microsoft#2680) Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
This was referenced Sep 18, 2026
Closed
Roman Lutz (romanlutz)
changed the title
Roman Lutz (romanlutz)
approved these changes
Sep 22, 2026
Roman Lutz (romanlutz)
enabled auto-merge
September 22, 2026 01:13
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2680.
Dismissing Scanner's Run preview dialog via either the Cancel button or Escape key left
document.activeElementon<body>rather than returning focus to the Launch scan button that opened the dialog.This change:
launchButtonRef).onOpenChangewhen closing, and the Cancel button handler).ScenarioDetail.test.tsxcovering focus restoration for both Cancel and Escape dismissal paths.Validation
npm test -- ScenarioDetail.test.tsx(43/43 tests pass)npm run type-checkpassesnpm run lintpasses with 0 warnings