Change return type of CredentialsContainer.create for WebAuthn#1742
Change return type of CredentialsContainer.create for WebAuthn#1742asmsuechan wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
|
@microsoft-github-policy-service agree |
|
This can be a problem when other types of credentials come, maybe there should be additional overload based on the value of |
|
@saschanaz Thank you for your comment! Yes, what you say is true. If it's unacceptable, I'll add the other interfaces above in this PR. I would love to know the manners of this repo first. |
|
Oops, FederatedCredential and PasswordCredential are supported only by Chrome.
According to the sentence, they don't meet the qualification.
So, |
Hi developers,
The return value for CredentialsContainer.create is one of
FederatedCredential,PasswordCredential, andPublicKeyCredentialaccording to https://developer.mozilla.org/en-US/docs/Web/API/CredentialsContainer/create#return_value
The return types are subclass of Credential. So I changed using
PublicKeyCredentialfromCredential. Note thatFederatedCredentialandPasswordCredentialhaven't been implemented yet, therefore, I didn't use them. I'll also try to create them after I learn the manners of this repo.Thank you for reading my PR.