Un‑consolidate and fix `WeakMap` constructor overloads by ExE-Boss · Pull Request #56713 · microsoft/TypeScript

ExE-Boss · 2023-12-08T12:53:57Z

Fixes #56664
Fixes #27951 for WeakMap.
Fixes #23551 which regressed as a result of #28052 only changing the Iterable‑taking constructor overload.

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_82,521	_82,521	_~	_~	_~	_{p=1.000 n=6}
_Types	_125,280	_125,280	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{277,173k (± 0.52%)}	_{277,223k (± 0.53%)}	_~	_274,231k	_277,985k	_{p=0.230 n=6}
_{Parse Time}	_{1.60s (± 1.14%)}	_{1.60s (± 1.23%)}	_~	_1.57s	_1.63s	_{p=0.739 n=6}
_{Bind Time}	_{0.90s (± 1.30%)}	_{0.90s (± 1.63%)}	_~	_0.88s	_0.92s	_{p=1.000 n=6}
_{Check Time}	_{17.51s (± 1.87%)}	_{17.50s (± 1.99%)}	_~	_16.81s	_17.77s	_{p=1.000 n=6}
_{Emit Time}	_{3.24s (± 1.30%)}	_{3.26s (± 0.60%)}	_~	_3.24s	_3.29s	_{p=0.332 n=6}
_{Total Time}	_{23.25s (± 1.52%)}	_{23.26s (± 1.51%)}	_~	_22.57s	_23.52s	_{p=1.000 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_955,840	_955,840	_~	_~	_~	_{p=1.000 n=6}
_Types	_415,853	_415,851	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,255,054k (± 0.00%)}	_{1,255,054k (± 0.01%)}	_~	_1,254,946k	_1,255,109k	_{p=0.810 n=6}
_{Parse Time}	_{7.99s (± 0.52%)}	_{7.94s (± 0.42%)}	_~	_7.89s	_7.98s	_{p=0.053 n=6}
_{Bind Time}	_{2.38s (± 0.75%)}	_{2.39s (± 0.64%)}	_~	_2.36s	_2.40s	_{p=0.683 n=6}
_{Check Time}	_{38.75s (± 0.34%)}	_{38.87s (± 0.37%)}	_~	_38.63s	_39.02s	_{p=0.090 n=6}
_{Emit Time}	_{17.96s (± 0.28%)}	_{18.02s (± 0.68%)}	_~	_17.82s	_18.16s	_{p=0.228 n=6}
_{Total Time}	_{67.07s (± 0.21%)}	_{67.23s (± 0.34%)}	_~	_66.86s	_67.48s	_{p=0.261 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	_11,439	_11,439	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,703,113	_2,703,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_931,060	_931,058	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,039,352k (± 0.00%)}	_{3,039,355k (± 0.00%)}	_~	_3,039,238k	_3,039,420k	_{p=0.936 n=6}
_{Parse Time}	_{12.65s (± 1.02%)}	_{12.70s (± 0.41%)}	_~	_12.62s	_12.78s	_{p=0.936 n=6}
_{Bind Time}	_{3.41s (± 0.88%)}	_{3.41s (± 0.91%)}	_~	_3.37s	_3.46s	_{p=0.871 n=6}
_{Check Time}	_{135.83s (± 0.95%)}	_{136.16s (± 1.52%)}	_~	_134.00s	_139.53s	_{p=0.936 n=6}
_{Emit Time}	_{0.46s (± 3.25%)}	_{0.47s (± 2.10%)}	_~	_0.45s	_0.48s	_{p=0.357 n=6}
_{Total Time}	_{152.36s (± 0.83%)}	_{152.75s (± 1.35%)}	_~	_150.56s	_156.09s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,253,400	_1,253,400	_~	_~	_~	_{p=1.000 n=6}
_Types	_260,196	_260,194	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,008,696k (± 9.92%)}	_{3,130,243k (± 0.03%)}	_~	_3,128,615k	_3,131,581k	_{p=0.936 n=6}
_{Parse Time}	_{6.67s (± 1.84%)}	_{6.71s (± 0.76%)}	_~	_6.62s	_6.78s	_{p=0.810 n=6}
_{Bind Time}	_{2.21s (± 1.58%)}	_{2.22s (± 0.68%)}	_~	_2.20s	_2.24s	_{p=0.936 n=6}
_{Check Time}	_{43.22s (± 0.32%)}	_{43.21s (± 0.46%)}	_~	_42.95s	_43.49s	_{p=1.000 n=6}
_{Emit Time}	_{3.47s (± 3.44%)}	_{3.51s (± 1.64%)}	_~	_3.42s	_3.58s	_{p=0.810 n=6}
_{Total Time}	_{55.58s (± 0.28%)}	_{55.64s (± 0.37%)}	_~	_55.35s	_55.92s	_{p=0.689 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,253,400	_1,253,400	_~	_~	_~	_{p=1.000 n=6}
_Types	_260,196	_260,194	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,194,656k (± 0.02%)}	_{3,193,786k (± 0.02%)}	_~	_3,193,298k	_3,194,584k	_{p=0.066 n=6}
_{Parse Time}	_{6.88s (± 0.73%)}	_{6.88s (± 1.14%)}	_~	_6.76s	_6.99s	_{p=1.000 n=6}
_{Bind Time}	_{2.27s (± 1.45%)}	_{2.25s (± 0.73%)}	_~	_2.22s	_2.27s	_{p=0.170 n=6}
_{Check Time}	_{43.43s (± 0.12%)}	_{43.39s (± 0.40%)}	_~	_43.17s	_43.66s	_{p=0.689 n=6}
_{Emit Time}	_{3.47s (± 3.73%)}	_{3.52s (± 2.27%)}	_~	_3.39s	_3.64s	_{p=0.470 n=6}
_{Total Time}	_{56.05s (± 0.26%)}	_{56.03s (± 0.30%)}	_~	_55.86s	_56.31s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,166	_265,166	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,270	_104,268	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{444,537k (± 0.02%)}	_{444,561k (± 0.01%)}	_~	_444,476k	_444,627k	_{p=0.575 n=6}
_{Parse Time}	_{3.53s (± 0.77%)}	_{3.52s (± 0.66%)}	_~	_3.49s	_3.56s	_{p=0.366 n=6}
_{Bind Time}	_{1.37s (± 0.55%)}	_{1.37s (± 0.75%)}	_~	_1.36s	_1.39s	_{p=0.437 n=6}
_{Check Time}	_{19.30s (± 0.46%)}	_{19.32s (± 0.29%)}	_~	_19.25s	_19.40s	_{p=0.872 n=6}
_{Emit Time}	_{1.55s (± 1.32%)}	_{1.54s (± 1.12%)}	_~	_1.52s	_1.57s	_{p=0.326 n=6}
_{Total Time}	_{25.75s (± 0.37%)}	_{25.75s (± 0.25%)}	_~	_25.66s	_25.84s	_{p=0.936 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₂₇₁	₂₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,135	_225,162	_{+27 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_93,554	_93,564	_{+10 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{370,625k (± 0.03%)}	_{370,613k (± 0.01%)}	_~	_370,551k	_370,669k	_{p=0.936 n=6}
_{Parse Time}	_{2.82s (± 1.58%)}	_{2.83s (± 1.04%)}	_~	_2.80s	_2.88s	_{p=0.169 n=6}
_{Bind Time}	_{1.64s (± 0.90%)}	_{1.63s (± 0.74%)}	_~	_1.62s	_1.65s	_{p=0.325 n=6}
_{Check Time}	_{17.44s (± 0.28%)}	_{17.43s (± 0.41%)}	_~	_17.31s	_17.50s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.91s (± 0.33%)}	_{21.90s (± 0.44%)}	_~	_21.76s	_22.01s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_4,226,927	_4,226,927	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,342,245	_1,342,247	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{4,019,894k (± 0.00%)}	_{4,019,962k (± 0.00%)}	_~	_4,019,764k	_4,020,183k	_{p=0.423 n=6}
_{Parse Time}	_{16.24s (± 0.49%)}	_{16.22s (± 0.34%)}	_~	_16.13s	_16.29s	_{p=0.810 n=6}
_{Bind Time}	_{5.78s (±12.98%)}	_{5.49s (± 0.41%)}	_~	_5.46s	_5.53s	_{p=0.936 n=6}
_{Check Time}	_{121.25s (± 3.76%)}	_{124.14s (± 3.75%)}	_~	_120.96s	_133.14s	_{p=0.298 n=6}
_{Emit Time}	_{49.95s (±10.48%)}	_{48.61s (± 9.67%)}	_~	_45.32s	_57.08s	_{p=0.689 n=6}
_{Total Time}	_{193.23s (± 3.08%)}	_{194.47s (± 3.01%)}	_~	_188.42s	_202.68s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₄₁	₄₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_402,249	_402,249	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,120	_178,122	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{559,168k (± 0.03%)}	_{559,224k (± 0.04%)}	_~	_559,001k	_559,660k	_{p=0.471 n=6}
_{Parse Time}	_{4.75s (± 0.67%)}	_{4.73s (± 0.13%)}	_~	_4.72s	_4.74s	_{p=0.158 n=6}
_{Bind Time}	_{2.02s (± 0.67%)}	_{2.02s (± 1.21%)}	_~	_1.99s	_2.06s	_{p=0.932 n=6}
_{Check Time}	_{24.48s (± 0.45%)}	_{24.41s (± 1.16%)}	_~	_23.94s	_24.75s	_{p=0.688 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.01s (±77.38%)}	_~	_0.00s	_0.01s	_{p=0.112 n=6}
_{Total Time}	_{31.26s (± 0.43%)}	_{31.17s (± 0.92%)}	_~	_30.67s	_31.51s	_{p=0.748 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_752,037	_752,037	_~	_~	_~	_{p=1.000 n=6}
_Types	_215,078	_215,076	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{675,357k (± 0.00%)}	_{675,398k (± 0.02%)}	_~	_675,242k	_675,566k	_{p=0.521 n=6}
_{Parse Time}	_{4.88s (± 0.42%)}	_{4.90s (± 0.42%)}	_~	_4.87s	_4.92s	_{p=0.517 n=6}
_{Bind Time}	_{1.57s (± 0.62%)}	_{1.58s (± 1.18%)}	_~	_1.55s	_1.60s	_{p=0.558 n=6}
_{Check Time}	_{22.26s (± 0.20%)}	_{22.34s (± 0.55%)}	_~	_22.17s	_22.53s	_{p=0.170 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.71s (± 0.20%)}	_{28.82s (± 0.45%)}	_~	_28.63s	_29.03s	_{p=0.054 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2026-02-06T23:19:10Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/56713/merge:

Everything looks good!

DanielRosenwasser

Don't love that there's more any, but most people were probably hitting the other overload anyway.

Un‑consolidate and fix WeakMap constructor overloads

ed75be4

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Dec 8, 2023

This was referenced Dec 8, 2023

Un-consolidate overloads for Map and WeakMap #28052

Merged

Can't extend WeakMap in type-checked JS files #56664

Closed

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 8, 2023

typescript-bot assigned sandersn Dec 8, 2023

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 8, 2023

Andarist reviewed Dec 8, 2023

View reviewed changes

src/lib/es2015.iterable.d.ts Show resolved Hide resolved

sandersn requested review from rbuckton and sandersn January 4, 2024 22:43

sandersn previously requested changes Jan 4, 2024

View reviewed changes

tests/cases/compiler/extendingCollectionsWithCheckJs.ts Show resolved Hide resolved

tests/cases/compiler/newMap.ts Show resolved Hide resolved

ExE-Boss requested a review from sandersn January 5, 2024 18:43

jakebailey added 2 commits February 6, 2026 13:51

Merge branch 'main' into pr-56713

5740829

update baselines

411d4e7

jakebailey removed the request for review from rbuckton February 6, 2026 22:00

DanielRosenwasser approved these changes Feb 7, 2026

View reviewed changes

github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Feb 7, 2026

jakebailey added this pull request to the merge queue Feb 7, 2026

Merged via the queue into microsoft:main with commit e872a6e Feb 7, 2026
23 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Un‑consolidate and fix `WeakMap` constructor overloads#56713

Un‑consolidate and fix `WeakMap` constructor overloads#56713
jakebailey merged 3 commits intomicrosoft:mainfrom
ExE-Boss:fix/gh-23551

ExE-Boss commented Dec 8, 2023 •

edited

Loading

Uh oh!

typescript-bot commented Dec 8, 2023

Uh oh!

Uh oh!

sandersn left a comment

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

tsc

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

DanielRosenwasser left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ExE-Boss commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 8, 2023

Uh oh!

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jakebailey commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

typescript-bot commented Feb 6, 2026

tsc

Uh oh!

typescript-bot commented Feb 6, 2026

Uh oh!

DanielRosenwasser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ExE-Boss commented Dec 8, 2023 •

edited

Loading

typescript-bot commented Feb 6, 2026 •

edited

Loading